components/password_manager/content/browser/visible_password_observer.h - Issue 2500213002: Track visible password fields by RenderFrameHost, not frame tree node

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/browser/visible_password_observer.h

Issue 2500213002: Track visible password fields by RenderFrameHost, not frame tree node (Closed)

Patch Set: fix unit test memory leak Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/content/browser/content_password_manager_driver_unittest.cc ('k') | components/password_manager/content/browser/visible_password_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/browser/visible_password_observer.h

diff --git a/components/password_manager/content/browser/visible_password_observer.h b/components/password_manager/content/browser/visible_password_observer.h

index d86331121ee0a0cf4cd1573d914898dc7b0b7249..40d9716b658ac014f732a5745cdc6b21daf73d1c 100644

--- a/components/password_manager/content/browser/visible_password_observer.h

+++ b/components/password_manager/content/browser/visible_password_observer.h

@@ -64,7 +64,7 @@ class VisiblePasswordObserver

void MaybeNotifyAllFieldsInvisible();

content::WebContents* web_contents_;

- std::set<int> frame_tree_nodes_with_visible_password_fields_;

+ std::set<content::RenderFrameHost*> frames_with_visible_password_fields_;

DISALLOW_COPY_AND_ASSIGN(VisiblePasswordObserver);

};