components/password_manager/content/browser/visible_password_observer.h - Issue 2500213002: Track visible password fields by RenderFrameHost, not frame tree node

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/password_manager/content/browser/visible_password_observer.h

Issue 2500213002: Track visible password fields by RenderFrameHost, not frame tree node (Closed)

Patch Set: fix unit test memory leak Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/password_manager/content/browser/content_password_manager_driver_unittest.cc ('k') | components/password_manager/content/browser/visible_password_observer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef COMPONENTS_PASSWORD_MANAGER_CONTENT_BROWSER_VISIBLE_PASSWORD_OBSERVER_H_	5 #ifndef COMPONENTS_PASSWORD_MANAGER_CONTENT_BROWSER_VISIBLE_PASSWORD_OBSERVER_H_

6 #define COMPONENTS_PASSWORD_MANAGER_CONTENT_BROWSER_VISIBLE_PASSWORD_OBSERVER_H_	6 #define COMPONENTS_PASSWORD_MANAGER_CONTENT_BROWSER_VISIBLE_PASSWORD_OBSERVER_H_

7	7

8 #include <set>	8 #include <set>

9	9

10 #include "base/compiler_specific.h"	10 #include "base/compiler_specific.h"

(...skipping 46 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
57	57

58 private:	58 private:

59 explicit VisiblePasswordObserver(content::WebContents* web_contents);	59 explicit VisiblePasswordObserver(content::WebContents* web_contents);

60 friend class content::WebContentsUserData<VisiblePasswordObserver>;	60 friend class content::WebContentsUserData<VisiblePasswordObserver>;

61	61

62 void MaybeNotifyPasswordInputShownOnHttp();	62 void MaybeNotifyPasswordInputShownOnHttp();

63	63

64 void MaybeNotifyAllFieldsInvisible();	64 void MaybeNotifyAllFieldsInvisible();

65	65

66 content::WebContents* web_contents_;	66 content::WebContents* web_contents_;

67 std::set<int> frame_tree_nodes_with_visible_password_fields_;	67 std::set<content::RenderFrameHost*> frames_with_visible_password_fields_;

68	68

69 DISALLOW_COPY_AND_ASSIGN(VisiblePasswordObserver);	69 DISALLOW_COPY_AND_ASSIGN(VisiblePasswordObserver);

70 };	70 };

71	71

72 } // namespace password_manager	72 } // namespace password_manager

73	73

74 #endif // COMPONENTS_PASSWORD_MANAGER_CONTENT_BROWSER_VISIBLE_PASSWORD_OBSERVER _H_	74 #endif // COMPONENTS_PASSWORD_MANAGER_CONTENT_BROWSER_VISIBLE_PASSWORD_OBSERVER _H_

OLD	NEW