Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 25002004: make v8::Locker not use Isolate::GetCurrent() (Closed)

Created:
7 years, 2 months ago by dcarney
Modified:
7 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

make v8::Locker not use Isolate::GetCurrent() R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16988

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -37 lines) Patch
M include/v8.h View 3 chunks +2 lines, -8 lines 0 comments Download
M src/d8.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/isolate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/v8threads.cc View 3 chunks +5 lines, -14 lines 0 comments Download
M test/cctest/test-api.cc View 4 chunks +12 lines, -9 lines 0 comments Download
M test/cctest/test-threads.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcarney
ptal
7 years, 2 months ago (2013-09-27 11:20:36 UTC) #1
Michael Starzinger
LGTM.
7 years, 2 months ago (2013-09-27 11:27:34 UTC) #2
dcarney
7 years, 2 months ago (2013-09-27 11:32:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16988 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698