chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java - Issue 2500183002: Do not parse JSON in the browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java

Issue 2500183002: Do not parse JSON in the browser. (Closed)

Patch Set: Use a Dictionary type in IDL Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentApp.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java

index 19a771064914b50e5b6a14a55981f844fece4f03..34f3ed8260ada6490e483aef3e56536479f6388e 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java

@@ -6,10 +6,9 @@ package org.chromium.chrome.browser.payments;

import android.graphics.drawable.Drawable;

-import org.json.JSONObject;

import org.chromium.chrome.browser.payments.ui.PaymentOption;

import org.chromium.payments.mojom.PaymentItem;

+import org.chromium.payments.mojom.PaymentMethodData;

import java.util.List;

@@ -65,7 +64,7 @@ public abstract class PaymentInstrument extends PaymentOption {

* @param callback The object that will receive the instrument details.

public abstract void getInstrumentDetails(String merchantName, String origin, PaymentItem total,

- List<PaymentItem> cart, JSONObject details, InstrumentDetailsCallback callback);

+ List<PaymentItem> cart, PaymentMethodData details, InstrumentDetailsCallback callback);

/**

* Cleans up any resources held by the payment instrument. For example, closes server