chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentApp.java - Issue 2500183002: Do not parse JSON in the browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentApp.java

Issue 2500183002: Do not parse JSON in the browser. (Closed)

Patch Set: Use a Dictionary type in IDL Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentApp.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentApp.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentApp.java

index bc76fa80a8248014a16cd5b178cc37d3037fbb76..106fa15860c15fd186b6c71850884b0254146e4c 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentApp.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentApp.java

@@ -4,7 +4,7 @@

package org.chromium.chrome.browser.payments;

-import org.json.JSONObject;

+import org.chromium.payments.mojom.PaymentMethodData;

import java.util.List;

import java.util.Map;

@@ -38,7 +38,7 @@ public interface PaymentApp {

* mode, merchant identifier, or a public key.

* @param callback The object that will receive the list of instruments.

- void getInstruments(Map<String, JSONObject> methodData, InstrumentsCallback callback);

+ void getInstruments(Map<String, PaymentMethodData> methodData, InstrumentsCallback callback);

/**

* Returns a list of all payment method names that this app supports. For example, ["visa",