Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4031)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApi.java

Issue 2500153003: Fix broken VR transitions due to ChromeTabbedActivity not being exported. (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApi.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApi.java b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApi.java
index e95ee912e52449ce92d0fcf7ebf6fddb21521273..6115370321f9af8e7d405b053689ec7e0100f501 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApi.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApi.java
@@ -5,6 +5,8 @@
package org.chromium.chrome.browser.vr_shell;
import android.app.PendingIntent;
+import android.content.ComponentName;
+import android.content.Intent;
/**
* Abstract away DaydreamImpl class, which may or may not be present at runtime depending on compile
@@ -14,7 +16,7 @@ public interface VrDaydreamApi {
/**
* Register the intent to launch after phone inserted into a Daydream viewer.
*/
- void registerDaydreamIntent(PendingIntent pendingIntent);
+ void registerDaydreamIntent(final PendingIntent pendingIntent);
/**
* Unregister the intent if any.
@@ -22,7 +24,23 @@ public interface VrDaydreamApi {
void unregisterDaydreamIntent();
/**
- * Close the private api.
+ * Create an Intent to launch a VR activity with the given component name.
*/
- void close();
+ Intent createVrIntent(final ComponentName componentName);
+
+ /**
+ * Launch the given Intent in VR mode.
+ */
+ void launchInVr(final PendingIntent pendingIntent);
+
+ /**
+ * @param requestCode The requestCode used by startActivityForResult.
+ * @param intent The data passed to VrCore as part of the exit request.
+ */
+ void exitFromVr(int requestCode, final Intent intent);
+
+ /**
+ * Sets VR Mode to |enabled|.
+ */
+ void setVrModeEnabled(boolean enabled);
}

Powered by Google App Engine
This is Rietveld 408576698