Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2057)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Issue 2500153003: Fix broken VR transitions due to ChromeTabbedActivity not being exported. (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
index d1a75b163ef9fbdd219680052813dd5b87ee9962..81e3f0a7f7ddf701bebd435b19ef3857e3e7ddb0 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
@@ -450,9 +450,6 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
if (getActivityTab() != null) getActivityTab().setIsAllowedToReturnToExternalApp(false);
- if (mVrShellDelegate.isVrInitialized()) {
- mVrShellDelegate.close();
- }
mTabModelSelectorImpl.saveState();
StartupMetrics.getInstance().recordHistogram(true);
mActivityStopMetrics.onStopWithNative(this);
@@ -482,9 +479,7 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
if (CommandLine.getInstance().hasSwitch(ContentSwitches.ENABLE_TEST_INTENTS)) {
handleDebugIntent(intent);
}
- if (!mVrShellDelegate.isInVR() && mVrShellDelegate.isVrIntent(intent)) {
- mVrShellDelegate.enterVRIfNecessary(false);
- }
+ if (mVrShellDelegate.isVrIntent(intent)) mVrShellDelegate.enterVRFromIntent(intent);
} finally {
TraceEvent.end("ChromeTabbedActivity.onNewIntentWithNative");
}
@@ -728,6 +723,9 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
}
}
return true;
+ } else if (requestCode == VrShellDelegate.EXIT_VR_RESULT) {
+ mVrShellDelegate.onExitVRResult(resultCode);
+ return true;
}
return false;
}
@@ -1240,7 +1238,7 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
if (!mUIInitialized) return false;
final Tab currentTab = getActivityTab();
- if (mVrShellDelegate.exitVRIfNecessary()) return true;
+ if (mVrShellDelegate.exitVRIfNecessary(true)) return true;
if (currentTab == null) {
recordBackPressedUma("currentTab is null", BACK_PRESSED_TAB_IS_NULL);

Powered by Google App Engine
This is Rietveld 408576698