Update dromaeo to upstream a876d5250befbc41e2deab9d10cf6085b511d5ed

Update dromeo to upstream a876d5250befbc41e2deab9d10cf6085b511d5ed

This cl is to update the folder with the newest version following instructions in https://cs.chromium.org/chromium/src/chrome/test/data/dromaeo/README.chromium
NOPRESUBMIT=true

Committed: https://crrev.com/5bf46168f1cd22646739bad1cc90e0ce47ff9dc5
Cr-Commit-Position: refs/heads/master@{#436773}

[dvallet, 2016-11-14 04:48:11]

Description was changed from

==========
Update dromeo test data after removing gender specific terms
See https://codereview.chromium.org/2489753002/ for more context.
I've removed gender specific terms from https://github.com/jeresig/dromaeo.
This cl is to update the folder with the newest version

BUG=542537
==========

to

==========
Update dromeo test data after removing gender specific terms
See https://codereview.chromium.org/2489753002/ for more context.
I've removed gender specific terms from https://github.com/jeresig/dromaeo.
This cl is to update the folder with the newest version following instructions
in https://cs.chromium.org/chromium/src/chrome/test/data/dromaeo/README.chromium


BUG=542537
==========

[dvallet, 2016-11-14 04:49:36]

Description was changed from

==========
Update dromeo test data after removing gender specific terms
See https://codereview.chromium.org/2489753002/ for more context.
I've removed gender specific terms from https://github.com/jeresig/dromaeo.
This cl is to update the folder with the newest version following instructions
in https://cs.chromium.org/chromium/src/chrome/test/data/dromaeo/README.chromium


BUG=542537
==========

to

==========
Update dromeo test data after removing gender specific terms
See https://codereview.chromium.org/2489753002/ for more context.
I've removed gender specific terms from https://github.com/jeresig/dromaeo.

This cl is to update the folder with the newest version following instructions
in https://cs.chromium.org/chromium/src/chrome/test/data/dromaeo/README.chromium

Note that gender fix is in:
https://codereview.chromium.org/2499923002/diff/10001/chrome/test/data/dromae...



BUG=542537
==========

[dvallet, 2016-11-14 04:50:47]

The CQ bit was checked by dvallet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 04:50:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 04:58:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 04:58:27]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dvallet, 2016-11-14 22:13:21]

dvallet@chromium.org changed reviewers:
+ asargent@chromium.org, thakis@chromium.org

[Nico, 2016-11-14 22:20:59]

Awesome, thanks for driving this!

Given that this is our first update to dromaeo in many years and given that I
think we run this on our perf tests, I'd make the commit message "update dromaeo
to upstream $commit_hash" since it brings in a bunch of other changes.

I'm a bit confused about this now loading stuff from the network; that seems
like it'd make perf fluctuate a lot. That's probably not an intentional change?

https://codereview.chromium.org/2499923002/diff/10001/chrome/test/data/dromae...
File chrome/test/data/dromaeo/tests/cssquery-jquery-2.x.html (right):

https://codereview.chromium.org/2499923002/diff/10001/chrome/test/data/dromae...
chrome/test/data/dromaeo/tests/cssquery-jquery-2.x.html:4: <script
src="https://ajax.googleapis.com/ajax/libs/jquery/2.0.3/jquery.min.js"></script>
Huh, the tests now grab jquery from the web?

https://codereview.chromium.org/2499923002/diff/10001/chrome/test/data/dromae...
File chrome/test/data/dromaeo/webrunner.js (left):

https://codereview.chromium.org/2499923002/diff/10001/chrome/test/data/dromae...
chrome/test/data/dromaeo/webrunner.js:809: // Add some more stuff if running in
automated mode.
we're not using this, yes?

[dvallet, 2016-11-15 02:19:39]

Bear in mind that this is basically my first CL send to Chromium, so any help is
appreciated!

https://codereview.chromium.org/2499923002/diff/10001/chrome/test/data/dromae...
File chrome/test/data/dromaeo/tests/cssquery-jquery-2.x.html (right):

https://codereview.chromium.org/2499923002/diff/10001/chrome/test/data/dromae...
chrome/test/data/dromaeo/tests/cssquery-jquery-2.x.html:4: <script
src="https://ajax.googleapis.com/ajax/libs/jquery/2.0.3/jquery.min.js"></script>
On 2016/11/14 22:20:58, Nico wrote:
> Huh, the tests now grab jquery from the web?

Looks like ../lib/jquery.js is still 1.2.6. I'm not sure if still using that
will affect the tests.
Would you suggest updating this from upstream?

https://codereview.chromium.org/2499923002/diff/10001/chrome/test/data/dromae...
File chrome/test/data/dromaeo/webrunner.js (left):

https://codereview.chromium.org/2499923002/diff/10001/chrome/test/data/dromae...
chrome/test/data/dromaeo/webrunner.js:809: // Add some more stuff if running in
automated mode.
On 2016/11/14 22:20:58, Nico wrote:
> we're not using this, yes?

Not really sure, it seems like it just adds some extra stuff, but I'm not sure
if in tests automated == true.

[Nico, 2016-11-15 15:30:06]

https://codereview.chromium.org/2499923002/diff/10001/chrome/test/data/dromae...
File chrome/test/data/dromaeo/tests/cssquery-jquery-2.x.html (right):

https://codereview.chromium.org/2499923002/diff/10001/chrome/test/data/dromae...
chrome/test/data/dromaeo/tests/cssquery-jquery-2.x.html:4: <script
src="https://ajax.googleapis.com/ajax/libs/jquery/2.0.3/jquery.min.js"></script>
On 2016/11/15 02:19:38, dvallet wrote:
> On 2016/11/14 22:20:58, Nico wrote:
> > Huh, the tests now grab jquery from the web?
> 
> Looks like ../lib/jquery.js is still 1.2.6. I'm not sure if still using that
> will affect the tests.
> Would you suggest updating this from upstream?

https://cs.chromium.org/search/?q=lib.jquery.js&sq=package:chromium&type=cs
suggests that only dromaeo uses that jquery, so updating it should be safe I
think.

https://codereview.chromium.org/2499923002/diff/10001/chrome/test/data/dromae...
File chrome/test/data/dromaeo/webrunner.js (left):

https://codereview.chromium.org/2499923002/diff/10001/chrome/test/data/dromae...
chrome/test/data/dromaeo/webrunner.js:809: // Add some more stuff if running in
automated mode.
On 2016/11/15 02:19:38, dvallet wrote:
> On 2016/11/14 22:20:58, Nico wrote:
> > we're not using this, yes?
> 
> Not really sure, it seems like it just adds some extra stuff, but I'm not sure
> if in tests automated == true.

The readme says "This benchmark was slightly modified to enable Chromium
automation.", so I'm wondering if this might be that.

Have you tried diffing the current in-tree dromaeo to the upstream dromaeo from
around the same time? (asargent, I don't suppose you remember anything about
this?)

[asargent_no_longer_on_chrome, 2016-11-15 17:39:58]

> Have you tried diffing the current in-tree dromaeo to the upstream dromaeo
from
> around the same time? (asargent, I don't suppose you remember anything about
> this?)

I don't, sorry.

[dvallet, 2016-11-15 23:18:06]

https://codereview.chromium.org/2499923002/diff/10001/chrome/test/data/dromae...
File chrome/test/data/dromaeo/tests/cssquery-jquery-2.x.html (right):

https://codereview.chromium.org/2499923002/diff/10001/chrome/test/data/dromae...
chrome/test/data/dromaeo/tests/cssquery-jquery-2.x.html:4: <script
src="https://ajax.googleapis.com/ajax/libs/jquery/2.0.3/jquery.min.js"></script>
On 2016/11/15 at 15:30:06, Nico wrote:
> On 2016/11/15 02:19:38, dvallet wrote:
> > On 2016/11/14 22:20:58, Nico wrote:
> > > Huh, the tests now grab jquery from the web?
> > 
> > Looks like ../lib/jquery.js is still 1.2.6. I'm not sure if still using that
> > will affect the tests.
> > Would you suggest updating this from upstream?
> 
> https://cs.chromium.org/search/?q=lib.jquery.js&sq=package:chromium&type=cs
suggests that only dromaeo uses that jquery, so updating it should be safe I
think.

Looks like this was a conscious decision by the developer:
https://github.com/jeresig/dromaeo/commit/4a1deedf06ca5374f6d01c6bd4c63405936...
What would be the best course of action here?
Since I need to update the other could anyway, I could modify these to point go
the ../lib/*.js files

https://codereview.chromium.org/2499923002/diff/10001/chrome/test/data/dromae...
File chrome/test/data/dromaeo/webrunner.js (left):

https://codereview.chromium.org/2499923002/diff/10001/chrome/test/data/dromae...
chrome/test/data/dromaeo/webrunner.js:809: // Add some more stuff if running in
automated mode.
On 2016/11/15 at 15:30:06, Nico wrote:
> On 2016/11/15 02:19:38, dvallet wrote:
> > On 2016/11/14 22:20:58, Nico wrote:
> > > we're not using this, yes?
> > 
> > Not really sure, it seems like it just adds some extra stuff, but I'm not
sure
> > if in tests automated == true.
> 
> The readme says "This benchmark was slightly modified to enable Chromium
automation.", so I'm wondering if this might be that.
> 
> Have you tried diffing the current in-tree dromaeo to the upstream dromaeo
from around the same time? (asargent, I don't suppose you remember anything
about this?)

I'm fairly certain that the automation bit was added in chromium only. E.g.,
this is the version that was used to do the last update:
https://github.com/jeresig/dromaeo/blob/776f3b1c61f4b025f25bc40c34ff42ee244cc...

My suggestion then is leave the automation here, but include the fix introduced
in
https://github.com/jeresig/dromaeo/commit/31de794e53bf69990660f52751b859fc52d...

[dvallet, 2016-11-17 05:50:33]

The CQ bit was checked by dvallet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 05:50:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 05:54:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 05:54:52]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)

[dvallet, 2016-11-17 05:55:16]

Description was changed from

==========
Update dromeo test data after removing gender specific terms
See https://codereview.chromium.org/2489753002/ for more context.
I've removed gender specific terms from https://github.com/jeresig/dromaeo.

This cl is to update the folder with the newest version following instructions
in https://cs.chromium.org/chromium/src/chrome/test/data/dromaeo/README.chromium

Note that gender fix is in:
https://codereview.chromium.org/2499923002/diff/10001/chrome/test/data/dromae...



BUG=542537
==========

to

==========
Update dromeo to upstream a876d5250befbc41e2deab9d10cf6085b511d5ed

This cl is to update the folder with the newest version following instructions
in https://cs.chromium.org/chromium/src/chrome/test/data/dromaeo/README.chromium
==========

[dvallet, 2016-11-17 06:17:47]

The CQ bit was checked by dvallet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 06:18:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dvallet, 2016-11-17 06:29:17]

PTAL
This is my current proposal: 
- Update tests to upstream
- Update javascript libraries in local to ones pointing to googleapis and modify
code to point to local libraries. 
- Added back automated code and include fix in median calculation

[commit-bot: I haz the power, 2016-11-17 06:30:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 06:30:01]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dvallet, 2016-11-21 23:18:05]

On 2016/11/17 at 06:29:17, dvallet wrote:
> PTAL
> This is my current proposal: 
> - Update tests to upstream
> - Update javascript libraries in local to ones pointing to googleapis and
modify code to point to local libraries. 
> - Added back automated code and include fix in median calculation

Friendly ping! This CL is now about updating the dromeo library.

[Nico, 2016-11-29 22:56:17]

lgtm, let's see how it goes.

For some of our third-party files we have a bunch of checked-in patches relative
to upstream to make the next update easier
(https://cs.chromium.org/search/?q=file:patches&sq=package:chromium&type=cs).
maybe that could make sense here too?

[dvallet, 2016-11-30 06:04:56]

On 2016/11/29 at 22:56:17, thakis wrote:
> lgtm, let's see how it goes.
> 
> For some of our third-party files we have a bunch of checked-in patches
relative to upstream to make the next update easier
(https://cs.chromium.org/search/?q=file:patches&sq=package:chromium&type=cs).
maybe that could make sense here too?

Thanks, I added the patch files, PTAL

[Nico, 2016-11-30 12:42:01]

The CQ bit was checked by thakis@chromium.org

[Nico, 2016-11-30 12:42:03]

lgtm

https://codereview.chromium.org/2499923002/diff/50001/chrome/test/data/dromae...
File chrome/test/data/dromaeo/README.chromium (right):

https://codereview.chromium.org/2499923002/diff/50001/chrome/test/data/dromae...
chrome/test/data/dromaeo/README.chromium:17: 4) apply patchs for webrunner and
references to libraries.
s/patchs/patches/, I'd reference the patches/ dir too. Maybe just"apply patches
in patches dir"?

[Nico, 2016-11-30 12:42:10]

The CQ bit was unchecked by thakis@chromium.org

[commit-bot: I haz the power, 2016-11-30 12:42:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dvallet, 2016-12-01 03:00:31]

The CQ bit was checked by dvallet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 03:00:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 03:12:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 03:12:05]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dvallet, 2016-12-01 03:34:48]

BTW presubmit fails due to this not being in third_party. I guess this needs to
be disable for commit?

https://codereview.chromium.org/2499923002/diff/50001/chrome/test/data/dromae...
File chrome/test/data/dromaeo/README.chromium (right):

https://codereview.chromium.org/2499923002/diff/50001/chrome/test/data/dromae...
chrome/test/data/dromaeo/README.chromium:17: 4) apply patchs for webrunner and
references to libraries.
On 2016/11/30 at 12:42:03, Nico wrote:
> s/patchs/patches/, I'd reference the patches/ dir too. Maybe just"apply
patches in patches dir"?

Done

[Nico, 2016-12-02 03:24:00]

Yes, since this just updates existing code, I think NOPRESUBMIT=yes in the CL
description should be appropriate here.

Maybe you could move this to third_party in a follow-up if you're up for that.
That seems like really the correct place for this.

[dvallet, 2016-12-02 03:45:27]

Description was changed from

==========
Update dromeo to upstream a876d5250befbc41e2deab9d10cf6085b511d5ed

This cl is to update the folder with the newest version following instructions
in https://cs.chromium.org/chromium/src/chrome/test/data/dromaeo/README.chromium
==========

to

==========
Update dromeo to upstream a876d5250befbc41e2deab9d10cf6085b511d5ed

This cl is to update the folder with the newest version following instructions
in https://cs.chromium.org/chromium/src/chrome/test/data/dromaeo/README.chromium
NOPRESUBMIT=yes
==========

[dvallet, 2016-12-02 03:47:02]

On 2016/12/02 at 03:24:00, thakis wrote:
> Yes, since this just updates existing code, I think NOPRESUBMIT=yes in the CL
description should be appropriate here.
> 
> Maybe you could move this to third_party in a follow-up if you're up for that.
That seems like really the correct place for this.

Thanks Nico. ACK, I'll look into it once submitted (and we check that nothing is
broken).

[dvallet, 2016-12-06 22:11:42]

The CQ bit was checked by dvallet@chromium.org

[dvallet, 2016-12-06 22:11:42]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2499923002/#ps60001
(title: "Modified readme")

[commit-bot: I haz the power, 2016-12-06 22:12:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 22:53:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 22:53:05]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dvallet, 2016-12-06 23:02:46]

Description was changed from

==========
Update dromeo to upstream a876d5250befbc41e2deab9d10cf6085b511d5ed

This cl is to update the folder with the newest version following instructions
in https://cs.chromium.org/chromium/src/chrome/test/data/dromaeo/README.chromium
NOPRESUBMIT=yes
==========

to

==========
Update dromeo to upstream a876d5250befbc41e2deab9d10cf6085b511d5ed

This cl is to update the folder with the newest version following instructions
in https://cs.chromium.org/chromium/src/chrome/test/data/dromaeo/README.chromium
NOPRESUBMIT=true
==========

[dvallet, 2016-12-06 23:03:02]

The CQ bit was checked by dvallet@chromium.org

[commit-bot: I haz the power, 2016-12-06 23:04:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 00:25:28]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481065382175100,
"parent_rev": "c13d2369716c6f2871ac7f7f68549e2dd9675601", "commit_rev":
"b51fcbb98a81060e7a3f991887d5b7111b12c9c7"}

[commit-bot: I haz the power, 2016-12-07 00:26:05]

Committed patchset #7 (id:60001)

[commit-bot: I haz the power, 2016-12-07 00:29:08]

Description was changed from

==========
Update dromeo to upstream a876d5250befbc41e2deab9d10cf6085b511d5ed

This cl is to update the folder with the newest version following instructions
in https://cs.chromium.org/chromium/src/chrome/test/data/dromaeo/README.chromium
NOPRESUBMIT=true
==========

to

==========
Update dromeo to upstream a876d5250befbc41e2deab9d10cf6085b511d5ed

This cl is to update the folder with the newest version following instructions
in https://cs.chromium.org/chromium/src/chrome/test/data/dromaeo/README.chromium
NOPRESUBMIT=true

Committed: https://crrev.com/5bf46168f1cd22646739bad1cc90e0ce47ff9dc5
Cr-Commit-Position: refs/heads/master@{#436773}
==========

[commit-bot: I haz the power, 2016-12-07 00:29:10]

Patchset 7 (id:??) landed as
https://crrev.com/5bf46168f1cd22646739bad1cc90e0ce47ff9dc5
Cr-Commit-Position: refs/heads/master@{#436773}