Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Unified Diff: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

Issue 2499853002: Fixed clip resize for document.rootScroller with inertTopControls (Closed)
Patch Set: Fixed issues + Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
index 26d508ee564501d5b14eaf35506be95f50cdaea7..3c40abf5eeac55fe8ef80d156e2a7f0e6e264c6e 100644
--- a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
+++ b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
@@ -2374,6 +2374,8 @@ TEST_P(VisualViewportTest, ResizeNonFixedBackgroundNoLayoutOrInvalidation) {
isSubtree);
EXPECT_EQ(0u, needsLayoutObjects);
+ webViewImpl->updateAllLifecyclePhases();
chrishtr 2016/11/18 00:37:09 Why this change?
bokan 2016/11/18 22:30:35 The viewportSizeChange call now causes a paint inv
+
// Do a real resize to check for invalidations.
document->view()->setTracksPaintInvalidations(true);
webViewImpl->resizeWithBrowserControls(WebSize(pageWidth, smallestHeight),

Powered by Google App Engine
This is Rietveld 408576698