Fixed clip resize for document.rootScroller with inertTopControls

third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/frame/VisualViewport.h"
 
 #include "core/dom/Document.h"
 #include "core/frame/BrowserControls.h"
 #include "core/frame/FrameHost.h"
 #include "core/frame/FrameView.h"
@@ skipping 2356 matching lines @@
   // setNeedsLayout from viewportSizeChanged.
   document->view()->viewportSizeChanged(false, true);
   unsigned needsLayoutObjects = 0;
   unsigned totalObjects = 0;
   bool isSubtree = false;
   EXPECT_FALSE(document->view()->needsLayout());
   document->view()->countObjectsNeedingLayout(needsLayoutObjects, totalObjects,
                                               isSubtree);
   EXPECT_EQ(0u, needsLayoutObjects);
 
+  webViewImpl->updateAllLifecyclePhases();

[chrishtr, 2016/11/18 00:37:09]

Why this change?

[bokan, 2016/11/18 22:30:35]

The viewportSizeChange call now causes a paint invalidation because of the
expanded clip. Turning on setTracksPaintInvalidations below asserts that
everything's clean.

+
   // Do a real resize to check for invalidations.
   document->view()->setTracksPaintInvalidations(true);
   webViewImpl->resizeWithBrowserControls(WebSize(pageWidth, smallestHeight),
                                          browserControlsHeight, true);
 
   // The layout size should not have changed.
   ASSERT_EQ(pageWidth, document->view()->layoutSize().width());
   ASSERT_EQ(smallestHeight, document->view()->layoutSize().height());
 
   const RasterInvalidationTracking* invalidationTracking =
@@ skipping 10 matching lines @@
   if (rootLayerScrolling)
     EXPECT_TRUE(invalidationTracking);
   else
     EXPECT_FALSE(invalidationTracking);
 
   document->view()->setTracksPaintInvalidations(false);
   RuntimeEnabledFeatures::setInertTopControlsEnabled(originalInertTopControls);
 }
 
 }  // namespace