Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1092)

Issue 24998007: Modify ZipString to allow the filename to be passed as an argument (Closed)

Created:
7 years, 2 months ago by Zachary Kuznia
Modified:
7 years, 2 months ago
Reviewers:
rkc
CC:
chromium-reviews
Visibility:
Public.

Description

Modify ZipString to allow the filename to be passed as an argument R=rkc@chromium.org BUG=299015 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226520

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M chrome/browser/feedback/feedback_data.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/feedback/feedback_util.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/feedback/feedback_util.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/feedback/tracing_manager.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Zachary Kuznia
7 years, 2 months ago (2013-09-27 20:19:59 UTC) #1
rkc
Thought I already LGTM'ed this, whoops. LGTM.
7 years, 2 months ago (2013-10-01 22:15:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/24998007/1
7 years, 2 months ago (2013-10-01 22:24:14 UTC) #3
commit-bot: I haz the power
Failed to apply patch for chrome/browser/feedback/feedback_data.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 2 months ago (2013-10-01 22:24:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/24998007/7001
7 years, 2 months ago (2013-10-01 22:51:18 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-01 23:54:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/24998007/7001
7 years, 2 months ago (2013-10-01 23:58:42 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-02 00:24:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/24998007/7001
7 years, 2 months ago (2013-10-02 17:45:19 UTC) #9
commit-bot: I haz the power
7 years, 2 months ago (2013-10-02 19:21:43 UTC) #10
Message was sent while issue was closed.
Change committed as 226520

Powered by Google App Engine
This is Rietveld 408576698