Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(884)

Unified Diff: chrome/browser/feedback/feedback_data.cc

Issue 24998007: Modify ZipString to allow the filename to be passed as an argument (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/feedback/feedback_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/feedback/feedback_data.cc
diff --git a/chrome/browser/feedback/feedback_data.cc b/chrome/browser/feedback/feedback_data.cc
index baf03ade5c243acd2c44631428d4fb0e1fa0d1c0..198ea03e19d6a504a847a65ab099c16cca2b502d 100644
--- a/chrome/browser/feedback/feedback_data.cc
+++ b/chrome/browser/feedback/feedback_data.cc
@@ -31,9 +31,12 @@ const char kMultilineEndString[] = "---------- END ----------\n\n";
const size_t kFeedbackMaxLength = 4 * 1024;
const size_t kFeedbackMaxLineCount = 40;
-const char kTraceFilename[] = "tracing.log\n";
+const char kTraceFilename[] = "tracing.zip\n";
const char kPerformanceCategoryTag[] = "Performance";
+const base::FilePath::CharType kLogsFilename[] =
+ FILE_PATH_LITERAL("system_logs.txt");
+
// Converts the system logs into a string that we can compress and send
// with the report. This method only converts those logs that we want in
// the compressed zip file sent with the report, hence it ignores any logs
@@ -69,7 +72,7 @@ void ZipLogs(FeedbackData::SystemLogsMap* sys_info,
DCHECK(compressed_logs);
std::string logs_string = LogsToString(sys_info);
if (logs_string.empty() ||
- !feedback_util::ZipString(logs_string, compressed_logs)) {
+ !feedback_util::ZipString(kLogsFilename, logs_string, compressed_logs)) {
compressed_logs->clear();
}
}
« no previous file with comments | « no previous file | chrome/browser/feedback/feedback_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698