Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2499573002: [turbofan] Fix a couple of invalid Uint32Constant/Int32Constant uses. (Closed)

Created:
4 years, 1 month ago by Benedikt Meurer
Modified:
4 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix a couple of invalid Uint32Constant/Int32Constant uses. The contract for TurboFan is that we use NumberConstants for any kind of number value until the representation selection picks concrete representations, i.e. Int32Constant or Float64Constant. We will soon be able to also guard this contract with DCHECKs. BUG=v8:5267 R=yangguo@chromium.org Committed: https://crrev.com/4ee6fdf38b89950f645d91a33a98c219869798f6 Cr-Commit-Position: refs/heads/master@{#40908}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M src/compiler/js-builtin-reducer.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M src/compiler/js-create-lowering.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/compiler/js-inlining.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-typed-lowering.cc View 6 chunks +6 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
Benedikt Meurer
4 years, 1 month ago (2016-11-11 07:42:08 UTC) #1
Yang
On 2016/11/11 07:42:08, Benedikt Meurer wrote: lgtm.
4 years, 1 month ago (2016-11-11 08:04:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2499573002/1
4 years, 1 month ago (2016-11-11 08:05:18 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 08:08:39 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:29:58 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ee6fdf38b89950f645d91a33a98c219869798f6
Cr-Commit-Position: refs/heads/master@{#40908}

Powered by Google App Engine
This is Rietveld 408576698