Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 2491943004: [turbofan] Also utilize the string length protector. (Closed)

Created:
4 years, 1 month ago by Benedikt Meurer
Modified:
4 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Also utilize the string length protector. Utilize the string length protector to deoptimize if the resulting string length for string addition overflows. This way we generate less code here and avoid holding on to the lazy frame state, and thus potentially reduce the number live ranges. BUG=v8:5267, v8:5404 R=yangguo@chromium.org Committed: https://crrev.com/ddba89c433170aa4618bc551da4c18327dfb6a81 Cr-Commit-Position: refs/heads/master@{#40909}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -24 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 chunk +35 lines, -24 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
Benedikt Meurer
4 years, 1 month ago (2016-11-11 07:55:31 UTC) #1
Yang
On 2016/11/11 07:55:31, Benedikt Meurer wrote: lgtm.
4 years, 1 month ago (2016-11-11 08:03:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2491943004/1
4 years, 1 month ago (2016-11-11 08:08:58 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 08:21:58 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:30:00 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ddba89c433170aa4618bc551da4c18327dfb6a81
Cr-Commit-Position: refs/heads/master@{#40909}

Powered by Google App Engine
This is Rietveld 408576698