Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5332)

Unified Diff: chrome/browser/extensions/extension_management.cc

Issue 2499493004: Communicate ExtensionSettings policy to renderers (Closed)
Patch Set: Fixed static non-pod, removed default params, fixed formatting, fixed nits, simplified code Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_management.cc
diff --git a/chrome/browser/extensions/extension_management.cc b/chrome/browser/extensions/extension_management.cc
index 727d20c99088bfa2df855f0331e652dee59fe548..c39cbee27ec958d44faa5442d4d67691b8ee003f 100644
--- a/chrome/browser/extensions/extension_management.cc
+++ b/chrome/browser/extensions/extension_management.cc
@@ -211,6 +211,16 @@ APIPermissionSet ExtensionManagement::GetBlockedAPIPermissions(
return default_settings_->blocked_permissions;
}
+const URLPatternSet& ExtensionManagement::GetDefaultRuntimeBlockedHosts()
+ const {
+ return default_settings_->runtime_blocked_hosts;
+}
+
+const URLPatternSet& ExtensionManagement::GetDefaultRuntimeAllowedHosts()
+ const {
+ return default_settings_->runtime_allowed_hosts;
+}
+
const URLPatternSet& ExtensionManagement::GetRuntimeBlockedHosts(
const Extension* extension) const {
auto iter_id = settings_by_id_.find(extension->id());
@@ -227,8 +237,13 @@ const URLPatternSet& ExtensionManagement::GetRuntimeAllowedHosts(
return default_settings_->runtime_allowed_hosts;
}
-bool ExtensionManagement::IsBlockedHost(const Extension* extension,
- const GURL& url) const {
+bool ExtensionManagement::UsesDefaultRuntimeHostRestrictions(
+ const Extension* extension) const {
dcheng 2017/02/06 07:05:29 Pass by const reference if it's never null? *shrug
nrpeter 2017/02/06 22:53:15 Everything else in extension_management that passe
dcheng 2017/02/07 07:47:12 I guess I'll defer to devlin on this one, but that
+ return (settings_by_id_.find(extension->id()) == settings_by_id_.end());
+}
+
+bool ExtensionManagement::IsRuntimeBlockedHost(const Extension* extension,
+ const GURL& url) const {
auto iter_id = settings_by_id_.find(extension->id());
if (iter_id != settings_by_id_.end())
return iter_id->second->runtime_blocked_hosts.MatchesURL(url);

Powered by Google App Engine
This is Rietveld 408576698