Communicate ExtensionSettings policy to renderers

chrome/browser/extensions/extension_management.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_management.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 193 matching lines @@
   }
   // Check whether if in one of them, setting is specified.
   if (iter_id != settings_by_id_.end())
     return iter_id->second->blocked_permissions;
   if (iter_update_url != settings_by_update_url_.end())
     return iter_update_url->second->blocked_permissions;
   // Fall back to the default blocked permissions setting.
   return default_settings_->blocked_permissions;
 }
 
+const URLPatternSet& ExtensionManagement::GetDefaultRuntimeBlockedHosts()
+    const {
+  return default_settings_->runtime_blocked_hosts;
+}
+
+const URLPatternSet& ExtensionManagement::GetDefaultRuntimeAllowedHosts()
+    const {
+  return default_settings_->runtime_allowed_hosts;
+}
+
 const URLPatternSet& ExtensionManagement::GetRuntimeBlockedHosts(
     const Extension* extension) const {
   auto iter_id = settings_by_id_.find(extension->id());
   if (iter_id != settings_by_id_.end())
     return iter_id->second->runtime_blocked_hosts;
   return default_settings_->runtime_blocked_hosts;
 }
 
 const URLPatternSet& ExtensionManagement::GetRuntimeAllowedHosts(
     const Extension* extension) const {
   auto iter_id = settings_by_id_.find(extension->id());
   if (iter_id != settings_by_id_.end())
     return iter_id->second->runtime_allowed_hosts;
   return default_settings_->runtime_allowed_hosts;
 }
 
-bool ExtensionManagement::IsBlockedHost(const Extension* extension,
-                                        const GURL& url) const {
+bool ExtensionManagement::UsesDefaultRuntimeHostRestrictions(
+    const Extension* extension) const {

[dcheng, 2017/02/06 07:05:29]

Pass by const reference if it's never null? *shrug*

[nrpeter, 2017/02/06 22:53:15]

Everything else in extension_management that passes an extension uses const *.
Would we rather have consistency or switch this to const &? I'm fine either way,
just let me know.

[dcheng, 2017/02/07 07:47:12]

I guess I'll defer to devlin on this one, but that's my preference (even if it
means it'll take some time to converge on a consistent style here).

+  return (settings_by_id_.find(extension->id()) == settings_by_id_.end());
+}
+
+bool ExtensionManagement::IsRuntimeBlockedHost(const Extension* extension,
+                                               const GURL& url) const {
   auto iter_id = settings_by_id_.find(extension->id());
   if (iter_id != settings_by_id_.end())
     return iter_id->second->runtime_blocked_hosts.MatchesURL(url);
   return default_settings_->runtime_blocked_hosts.MatchesURL(url);
 }
 
 std::unique_ptr<const PermissionSet> ExtensionManagement::GetBlockedPermissions(
     const Extension* extension) const {
   // Only api permissions are supported currently.
   return std::unique_ptr<const PermissionSet>(new PermissionSet(
@@ skipping 279 matching lines @@
     content::BrowserContext* context) const {
   return chrome::GetBrowserContextRedirectedInIncognito(context);
 }
 
 void ExtensionManagementFactory::RegisterProfilePrefs(
     user_prefs::PrefRegistrySyncable* user_prefs) {
   user_prefs->RegisterDictionaryPref(pref_names::kExtensionManagement);
 }
 
 }  // namespace extensions