third_party/WebKit/LayoutTests/http/tests/feature-policy/resources/feature-policy-fullscreen-disabled.html - Issue 2499373002: Implementation for feature policy - fullscreen

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/feature-policy/resources/feature-policy-fullscreen-disabled.html

Issue 2499373002: Implementation for feature policy - fullscreen (Closed)

Patch Set: Modified layout tests Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« third_party/WebKit/LayoutTests/http/tests/feature-policy/fullscreen-enabledforself.php ('K') | « third_party/WebKit/LayoutTests/http/tests/feature-policy/fullscreen-enabledforself.php ('k') | third_party/WebKit/LayoutTests/http/tests/feature-policy/resources/feature-policy-fullscreen-enabled.html » ('j') | third_party/WebKit/Source/core/dom/Fullscreen.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <head>

	3 <title>Feature-Policy Fullscreen Disabled</title>

	4 <script src="/resources/testharness.js"></script>

	5 <script src="/resources/testharnessreport.js"></script>

	6 </head>

	7 <script>

	8 test(function(test) {
	foolip 2016/11/28 23:33:22 Should be async_test? Should be async_test? lunalu1 2016/12/01 20:10:07 Done. Show quoted text On 2016/11/28 23:33:22, foolip wrote: > Should be async_test? Done.
	9 document.onwebkitfullscreenerror = function ( event ) {
	foolip 2016/11/28 23:33:22 If async, test, wrap in test.step_func. You can al If async, test, wrap in test.step_func. You can also omit the unused argument. lunalu1 2016/12/01 20:10:07 Done. Show quoted text On 2016/11/28 23:33:22, foolip wrote: > If async, test, wrap in test.step_func. You can also omit the unused argument. Done.
	10 console.log('FULL SCREEN DENIED');
	foolip 2016/11/28 23:33:22 Is this needed? If the result of the test matters, Is this needed? If the result of the test matters, then passing the test should be enough. And if the test result in the iframes don't matter, it would be more clear to not use testharness.js here. lunalu1 2016/12/01 20:10:07 Done. Show quoted text On 2016/11/28 23:33:22, foolip wrote: > Is this needed? If the result of the test matters, then passing the test should > be enough. And if the test result in the iframes don't matter, it would be more > clear to not use testharness.js here. Done.
	11 test.done();

	12 document.webkitExitFullscreen();

	13 };

	14 var div = document.createElement('div');

	15 document.documentElement.appendChild(div);
	foolip 2016/11/28 23:33:22 A div in the markup and document.querySelector('di A div in the markup and document.querySelector('div') would work, and makes it clear that there's nothing special about the parent of the div. (Being a sibling of head and body is unusual.) lunalu1 2016/12/01 20:10:07 Done. Show quoted text On 2016/11/28 23:33:22, foolip wrote: > A div in the markup and document.querySelector('div') would work, and makes it > clear that there's nothing special about the parent of the div. (Being a sibling > of head and body is unusual.) Done.
	16 assert_false(document.fullscreenEnabled);
	foolip 2016/11/28 23:33:22 Using the prefixed or unprefixed API consistently Using the prefixed or unprefixed API consistently would be good. lunalu1 2016/12/01 20:10:07 Done. Show quoted text On 2016/11/28 23:33:22, foolip wrote: > Using the prefixed or unprefixed API consistently would be good. Done.
	17 div.webkitRequestFullscreen();
	foolip 2016/11/28 23:33:22 Without a user gesture the request will fail with Without a user gesture the request will fail with or without feature policy. The tests deleted in https://codereview.chromium.org/2466333002 are one way of writing fullscreen tests that you could copy, but more directly you can just use eventSender.
	18 }, 'No iframe may use fullscreen feature when disabled.');

	19 </script>

OLD	NEW