Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2466333002: Automate Fullscreen web-platform-tests using wpt_automation (Closed)

Created:
4 years, 1 month ago by foolip
Modified:
4 years, 1 month ago
Reviewers:
eae, Rick Byers
CC:
chromium-reviews, blink-reviews, tfarina, blink-reviews-w3ctests_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Automate Fullscreen web-platform-tests using wpt_automation BUG=660846 Committed: https://crrev.com/529fd9c41df97f26fd8e3ff26222f3ae195365d6 Cr-Commit-Position: refs/heads/master@{#429118}

Patch Set 1 #

Patch Set 2 : update line numbers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -450 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 2 chunks +1 line, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/fullscreen/api/document-exit-fullscreen.html View 1 chunk +0 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/fullscreen/api/document-fullscreen-element.html View 2 chunks +4 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/fullscreen/api/document-onfullscreenchange.html View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/fullscreen/api/element-ready-check-containing-iframe.html View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/fullscreen/api/element-ready-check-enabled-flag-not-set.html View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/fullscreen/api/element-ready-check-fullscreen-element-sibling.html View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/LayoutTests/fullscreen/api/element-ready-check-fullscreen-iframe-child.html View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/LayoutTests/fullscreen/api/element-ready-check-iframe-child.html View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/fullscreen/api/element-ready-check-not-in-document.html View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/fullscreen/api/element-request-fullscreen.html View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/fullscreen/api/element-request-fullscreen-non-top.html View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/LayoutTests/fullscreen/api/element-request-fullscreen-top.html View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/LayoutTests/fullscreen/model/remove-child.html View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/LayoutTests/fullscreen/model/remove-first.html View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/WebKit/LayoutTests/fullscreen/model/remove-last.html View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/WebKit/LayoutTests/fullscreen/model/remove-parent.html View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/fullscreen/model/remove-single.html View 1 chunk +0 lines, -24 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/document-fullscreen-element-manual-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-svg-rect-manual-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/the-img-element/update-the-source-set-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/resources/testharnessreport.js View 1 chunk +30 lines, -22 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt_automation/fullscreen/auto-click.js View 1 chunk +36 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/resources/testharnessreport.js View 1 chunk +30 lines, -22 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
foolip
PTAL. I'm quite skeptical that the wpt_automation approach will scale, but having shared manual tests ...
4 years, 1 month ago (2016-11-01 13:15:15 UTC) #2
eae
OK, let's try it. LGTM
4 years, 1 month ago (2016-11-01 16:11:56 UTC) #8
Rick Byers
LGTM I'll be interested to hear how this works out. I'm anxious to have standard ...
4 years, 1 month ago (2016-11-01 20:29:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2466333002/20001
4 years, 1 month ago (2016-11-01 20:34:12 UTC) #12
foolip
On 2016/11/01 20:29:10, Rick Byers wrote: > LGTM > I'll be interested to hear how ...
4 years, 1 month ago (2016-11-01 20:37:02 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-01 21:34:53 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 21:39:38 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/529fd9c41df97f26fd8e3ff26222f3ae195365d6
Cr-Commit-Position: refs/heads/master@{#429118}

Powered by Google App Engine
This is Rietveld 408576698