Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2499343002: [DevTools] Introduce DevToolsSession. (Closed)

Created:
4 years, 1 month ago by dgozman
Modified:
4 years, 1 month ago
Reviewers:
caseq
CC:
chromium-reviews, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Introduce DevToolsSession. This class so far encapsulates session id and dispatcher. Going forward, it will also contain domain handlers and client (for multi-client support). BUG=664683, 590878 TBR=pfeldman Committed: https://crrev.com/d77188631f0c3503585d1e5971366208a0752a38 Cr-Commit-Position: refs/heads/master@{#432343}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -26 lines) Patch
M content/browser/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/devtools/browser_devtools_agent_host.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/devtools/devtools_agent_host_impl.h View 4 chunks +5 lines, -2 lines 0 comments Download
M content/browser/devtools/devtools_agent_host_impl.cc View 6 chunks +6 lines, -4 lines 0 comments Download
A content/browser/devtools/devtools_session.h View 1 chunk +30 lines, -0 lines 0 comments Download
A content/browser/devtools/devtools_session.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M content/browser/devtools/forwarding_agent_host.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 4 chunks +16 lines, -11 lines 0 comments Download
M content/browser/devtools/worker_devtools_agent_host.cc View 4 chunks +9 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (11 generated)
dgozman
Could you please take a look?
4 years, 1 month ago (2016-11-15 18:31:23 UTC) #2
caseq
lgtm
4 years, 1 month ago (2016-11-15 18:41:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2499343002/1
4 years, 1 month ago (2016-11-15 23:58:17 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/305046)
4 years, 1 month ago (2016-11-16 00:18:17 UTC) #11
dgozman
TBR'ing pfeldman for content/browser/BUILD.gn
4 years, 1 month ago (2016-11-16 00:29:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2499343002/1
4 years, 1 month ago (2016-11-16 00:30:14 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 01:35:12 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 01:38:33 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d77188631f0c3503585d1e5971366208a0752a38
Cr-Commit-Position: refs/heads/master@{#432343}

Powered by Google App Engine
This is Rietveld 408576698