[DevTools] Use inspector_protocol generator in content/browser/devtools.

[DevTools] Use inspector_protocol generator in content/browser/devtools.

This required rolling inspector_protocol to ae736f1e3ac306688c2d7feaa4f43dbdded01ed3:
- [inspector_protocol] Support chromium code style.

BUG=664683
TBR=pfeldman

Committed: https://crrev.com/dc4d41727b85a3a2d92499c923fc5614e97dd241
Cr-Commit-Position: refs/heads/master@{#432276}

[dgozman, 2016-11-12 00:53:45]

dgozman@chromium.org changed reviewers:
+ caseq@chromium.org, kozyatinskiy@chromium.org

[dgozman, 2016-11-12 00:53:45]

Could you please take a look?

[caseq, 2016-11-12 02:17:04]

lgtm

https://codereview.chromium.org/2493063005/diff/1/content/browser/devtools/pr...
File content/browser/devtools/protocol_string.cc (right):

https://codereview.chromium.org/2493063005/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol_string.cc:43: DCHECK(list);
drop it?

https://codereview.chromium.org/2493063005/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol_string.cc:48: DCHECK(item);
ditto.

https://codereview.chromium.org/2493063005/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol_string.cc:59: DCHECK(dictionary);
ditto.

https://codereview.chromium.org/2493063005/diff/1/content/browser/devtools/pr...
File content/browser/devtools/protocol_string.h (right):

https://codereview.chromium.org/2493063005/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol_string.h:18: class CONTENT_EXPORT
ProtocolStringBuilder {
perhaps get it into protocol or otherwise avoid exposing to content?

https://codereview.chromium.org/2493063005/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol_string.h:29: std::vector<char> buffer_;
let's just += a string.

https://codereview.chromium.org/2493063005/diff/1/third_party/inspector_proto...
File third_party/inspector_protocol/CodeGenerator.py (right):

https://codereview.chromium.org/2493063005/diff/1/third_party/inspector_proto...
third_party/inspector_protocol/CodeGenerator.py:123: def to_snake_case(name):
return re.sub(r'(?<=[a-z])([A-Z])', r'_\1', name, sys.maxint).lower()

https://codereview.chromium.org/2493063005/diff/1/third_party/inspector_proto...
third_party/inspector_protocol/CodeGenerator.py:198: for domain in
protocol.imported_domains:
imported_domains = list(set(protocol.imported_domains) -
set(protocol.generate_domains))

[dgozman, 2016-11-14 18:40:28]

All done.

https://codereview.chromium.org/2493063005/diff/1/content/browser/devtools/pr...
File content/browser/devtools/protocol_string.cc (right):

https://codereview.chromium.org/2493063005/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol_string.cc:43: DCHECK(list);
On 2016/11/12 02:17:04, caseq wrote:
> drop it?

Done.

https://codereview.chromium.org/2493063005/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol_string.cc:48: DCHECK(item);
On 2016/11/12 02:17:04, caseq wrote:
> ditto.

Done.

https://codereview.chromium.org/2493063005/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol_string.cc:59: DCHECK(dictionary);
On 2016/11/12 02:17:04, caseq wrote:
> ditto.

Done.

https://codereview.chromium.org/2493063005/diff/1/content/browser/devtools/pr...
File content/browser/devtools/protocol_string.h (right):

https://codereview.chromium.org/2493063005/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol_string.h:18: class CONTENT_EXPORT
ProtocolStringBuilder {
On 2016/11/12 02:17:04, caseq wrote:
> perhaps get it into protocol or otherwise avoid exposing to content?

Done.

https://codereview.chromium.org/2493063005/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol_string.h:29: std::vector<char> buffer_;
On 2016/11/12 02:17:04, caseq wrote:
> let's just += a string.

Done.

https://codereview.chromium.org/2493063005/diff/1/third_party/inspector_proto...
File third_party/inspector_protocol/CodeGenerator.py (right):

https://codereview.chromium.org/2493063005/diff/1/third_party/inspector_proto...
third_party/inspector_protocol/CodeGenerator.py:123: def to_snake_case(name):
On 2016/11/12 02:17:04, caseq wrote:
> return re.sub(r'(?<=[a-z])([A-Z])', r'_\1', name, sys.maxint).lower()

Done.

https://codereview.chromium.org/2493063005/diff/1/third_party/inspector_proto...
third_party/inspector_protocol/CodeGenerator.py:198: for domain in
protocol.imported_domains:
On 2016/11/12 02:17:04, caseq wrote:
> imported_domains = list(set(protocol.imported_domains) -
> set(protocol.generate_domains))

Done.

[dgozman, 2016-11-14 19:28:41]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 19:29:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 19:52:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 19:52:27]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[dgozman, 2016-11-14 20:49:45]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 20:50:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 21:28:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 21:28:05]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[dgozman, 2016-11-15 01:27:56]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 01:28:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 03:46:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 03:46:08]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-11-15 17:10:06]

Description was changed from

==========
[DevTools] Use inspector_protocol generator in content/browser/devtools.

BUG=664683
==========

to

==========
[DevTools] Use inspector_protocol generator in content/browser/devtools.

This required rolling inspector_protocol to
ae736f1e3ac306688c2d7feaa4f43dbdded01ed3:
- [inspector_protocol] Support chromium code style.

BUG=664683
==========

[dgozman, 2016-11-15 17:16:52]

Description was changed from

==========
[DevTools] Use inspector_protocol generator in content/browser/devtools.

This required rolling inspector_protocol to
ae736f1e3ac306688c2d7feaa4f43dbdded01ed3:
- [inspector_protocol] Support chromium code style.

BUG=664683
==========

to

==========
[DevTools] Use inspector_protocol generator in content/browser/devtools.

This required rolling inspector_protocol to
ae736f1e3ac306688c2d7feaa4f43dbdded01ed3:
- [inspector_protocol] Support chromium code style.

BUG=664683
TBR=pfeldman
==========

[dgozman, 2016-11-15 17:17:08]

TBR'ing pfeldman for content/browser/BUILD.gn

[dgozman, 2016-11-15 17:17:12]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-11-15 17:17:13]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2493063005/#ps80001
(title: "roll")

[commit-bot: I haz the power, 2016-11-15 17:17:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 21:21:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 21:21:40]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dgozman, 2016-11-15 22:04:43]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-11-15 22:05:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 22:41:26]

Description was changed from

==========
[DevTools] Use inspector_protocol generator in content/browser/devtools.

This required rolling inspector_protocol to
ae736f1e3ac306688c2d7feaa4f43dbdded01ed3:
- [inspector_protocol] Support chromium code style.

BUG=664683
TBR=pfeldman
==========

to

==========
[DevTools] Use inspector_protocol generator in content/browser/devtools.

This required rolling inspector_protocol to
ae736f1e3ac306688c2d7feaa4f43dbdded01ed3:
- [inspector_protocol] Support chromium code style.

BUG=664683
TBR=pfeldman
==========

[commit-bot: I haz the power, 2016-11-15 22:41:27]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-11-15 22:46:32]

Description was changed from

==========
[DevTools] Use inspector_protocol generator in content/browser/devtools.

This required rolling inspector_protocol to
ae736f1e3ac306688c2d7feaa4f43dbdded01ed3:
- [inspector_protocol] Support chromium code style.

BUG=664683
TBR=pfeldman
==========

to

==========
[DevTools] Use inspector_protocol generator in content/browser/devtools.

This required rolling inspector_protocol to
ae736f1e3ac306688c2d7feaa4f43dbdded01ed3:
- [inspector_protocol] Support chromium code style.

BUG=664683
TBR=pfeldman

Committed: https://crrev.com/dc4d41727b85a3a2d92499c923fc5614e97dd241
Cr-Commit-Position: refs/heads/master@{#432276}
==========

[commit-bot: I haz the power, 2016-11-15 22:46:33]

Patchset 5 (id:??) landed as
https://crrev.com/dc4d41727b85a3a2d92499c923fc5614e97dd241
Cr-Commit-Position: refs/heads/master@{#432276}