Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1506)

Unified Diff: content/common/navigation_params.h

Issue 2499313003: Set user_gesture bit at NavigationHandle creation time. (Closed)
Patch Set: remove gesture dcheck Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/navigation_params.h
diff --git a/content/common/navigation_params.h b/content/common/navigation_params.h
index 98757a7303b941944faab686f576dac7240c021c..ad0f6ff7996a5802947b86f28db89d34f8f72f82 100644
--- a/content/common/navigation_params.h
+++ b/content/common/navigation_params.h
@@ -15,6 +15,7 @@
#include "build/build_config.h"
#include "content/common/content_export.h"
#include "content/common/frame_message_enums.h"
+#include "content/common/navigation_gesture.h"
#include "content/common/resource_request_body_impl.h"
#include "content/public/common/page_state.h"
#include "content/public/common/referrer.h"
@@ -144,7 +145,7 @@ struct CONTENT_EXPORT BeginNavigationParams {
BeginNavigationParams();
BeginNavigationParams(std::string headers,
int load_flags,
- bool has_user_gesture,
+ NavigationGesture gesture,
bool skip_service_worker,
RequestContextType request_context_type);
BeginNavigationParams(const BeginNavigationParams& other);
@@ -155,8 +156,8 @@ struct CONTENT_EXPORT BeginNavigationParams {
// net::URLRequest load flags (net::LOAD_NORMAL) by default).
int load_flags;
- // True if the request was user initiated.
- bool has_user_gesture;
+ // Indicates the gesture type.
+ NavigationGesture gesture;
// True if the ServiceWorker should be skipped.
bool skip_service_worker;
@@ -233,7 +234,7 @@ struct CONTENT_EXPORT RequestNavigationParams {
int current_history_list_length,
bool is_view_source,
bool should_clear_history_list,
- bool has_user_gesture);
+ NavigationGesture gesture);
RequestNavigationParams(const RequestNavigationParams& other);
~RequestNavigationParams();
@@ -325,8 +326,8 @@ struct CONTENT_EXPORT RequestNavigationParams {
// it will always be equal to kInvalidServiceWorkerProviderId.
int service_worker_provider_id;
- // True if the navigation originated due to a user gesture.
- bool has_user_gesture;
+ // Indicates the gesture type.
+ NavigationGesture gesture;
#if defined(OS_ANDROID)
// The real content of the data: URL. Only used in Android WebView for

Powered by Google App Engine
This is Rietveld 408576698