Set user_gesture bit at NavigationHandle creation time.

content/common/navigation_params.cc

Index: content/common/navigation_params.cc
diff --git a/content/common/navigation_params.cc b/content/common/navigation_params.cc
index d6d1eb1abaafe537f722ff4ff2a496ea0fdc7030..2457037185ee418288546b8151ae3d84a782a7b0 100644
--- a/content/common/navigation_params.cc
+++ b/content/common/navigation_params.cc
@@ -81,19 +81,19 @@ CommonNavigationParams::~CommonNavigationParams() {
 
 BeginNavigationParams::BeginNavigationParams()
     : load_flags(0),
-      has_user_gesture(false),
+      gesture(NavigationGestureAuto),

[Bryan McQuade, 2016/11/19 20:21:39]

should this default to NavigationGestureAuto or NavigationGestureUnknown?

[clamy, 2016/11/21 16:50:46]

I'd say NavigationGestureUnknown.

[Bryan McQuade, 2016/11/22 14:13:03]

Done (in CommonNavParams)

       skip_service_worker(false),
       request_context_type(REQUEST_CONTEXT_TYPE_LOCATION) {}
 
 BeginNavigationParams::BeginNavigationParams(
     std::string headers,
     int load_flags,
-    bool has_user_gesture,
+    NavigationGesture gesture,
     bool skip_service_worker,
     RequestContextType request_context_type)
     : headers(headers),
       load_flags(load_flags),
-      has_user_gesture(has_user_gesture),
+      gesture(gesture),
       skip_service_worker(skip_service_worker),
       request_context_type(request_context_type) {}
 
@@ -135,7 +135,7 @@ RequestNavigationParams::RequestNavigationParams()
       should_clear_history_list(false),
       should_create_service_worker(false),
       service_worker_provider_id(kInvalidServiceWorkerProviderId),
-      has_user_gesture(false) {}
+      gesture(NavigationGestureAuto) {}

[Bryan McQuade, 2016/11/19 20:21:39]

same - auto or unknown here?

[clamy, 2016/11/21 16:50:46]

See comment below.

[Bryan McQuade, 2016/11/22 14:13:03]

Done

 
 RequestNavigationParams::RequestNavigationParams(
     bool is_overriding_user_agent,
@@ -153,7 +153,7 @@ RequestNavigationParams::RequestNavigationParams(
     int current_history_list_length,
     bool is_view_source,
     bool should_clear_history_list,
-    bool has_user_gesture)
+    NavigationGesture gesture)

[clamy, 2016/11/21 16:50:46]

Since it seems it is both used in RequestNavigationParams &
BeginNavigationParams, could we move it to CommonNavigationParams, which is sent
in all navigation IPCs, instead of having it in two different structs? Thanks!

[Bryan McQuade, 2016/11/22 14:13:03]

Ah, sure, done.

     : is_overriding_user_agent(is_overriding_user_agent),
       redirects(redirects),
       can_load_local_resources(can_load_local_resources),
@@ -171,7 +171,7 @@ RequestNavigationParams::RequestNavigationParams(
       should_clear_history_list(should_clear_history_list),
       should_create_service_worker(false),
       service_worker_provider_id(kInvalidServiceWorkerProviderId),
-      has_user_gesture(has_user_gesture) {}
+      gesture(gesture) {}
 
 RequestNavigationParams::RequestNavigationParams(
     const RequestNavigationParams& other) = default;