Set user_gesture bit at NavigationHandle creation time.

content/common/navigation_params.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/navigation_params.h"
 
 #include "base/logging.h"
 #include "build/build_config.h"
 #include "content/common/service_worker/service_worker_types.h"
 #include "content/public/common/browser_side_navigation_policy.h"
@@ skipping 63 matching lines @@
 }
 
 CommonNavigationParams::CommonNavigationParams(
     const CommonNavigationParams& other) = default;
 
 CommonNavigationParams::~CommonNavigationParams() {
 }
 
 BeginNavigationParams::BeginNavigationParams()
     : load_flags(0),
-      has_user_gesture(false),
+      gesture(NavigationGestureAuto),

[Bryan McQuade, 2016/11/19 20:21:39]

should this default to NavigationGestureAuto or NavigationGestureUnknown?

[clamy, 2016/11/21 16:50:46]

I'd say NavigationGestureUnknown.

[Bryan McQuade, 2016/11/22 14:13:03]

Done (in CommonNavParams)

       skip_service_worker(false),
       request_context_type(REQUEST_CONTEXT_TYPE_LOCATION) {}
 
 BeginNavigationParams::BeginNavigationParams(
     std::string headers,
     int load_flags,
-    bool has_user_gesture,
+    NavigationGesture gesture,
     bool skip_service_worker,
     RequestContextType request_context_type)
     : headers(headers),
       load_flags(load_flags),
-      has_user_gesture(has_user_gesture),
+      gesture(gesture),
       skip_service_worker(skip_service_worker),
       request_context_type(request_context_type) {}
 
 BeginNavigationParams::BeginNavigationParams(
     const BeginNavigationParams& other) = default;
 
 StartNavigationParams::StartNavigationParams()
     : transferred_request_child_id(-1),
       transferred_request_request_id(-1) {
 }
@@ skipping 21 matching lines @@
       is_history_navigation_in_new_child(false),
       has_committed_real_load(false),
       intended_as_new_entry(false),
       pending_history_list_offset(-1),
       current_history_list_offset(-1),
       current_history_list_length(0),
       is_view_source(false),
       should_clear_history_list(false),
       should_create_service_worker(false),
       service_worker_provider_id(kInvalidServiceWorkerProviderId),
-      has_user_gesture(false) {}
+      gesture(NavigationGestureAuto) {}

[Bryan McQuade, 2016/11/19 20:21:39]

same - auto or unknown here?

[clamy, 2016/11/21 16:50:46]

See comment below.

[Bryan McQuade, 2016/11/22 14:13:03]

Done

 
 RequestNavigationParams::RequestNavigationParams(
     bool is_overriding_user_agent,
     const std::vector<GURL>& redirects,
     bool can_load_local_resources,
     const PageState& page_state,
     int nav_entry_id,
     bool is_same_document_history_load,
     bool is_history_navigation_in_new_child,
     std::map<std::string, bool> subframe_unique_names,
     bool has_committed_real_load,
     bool intended_as_new_entry,
     int pending_history_list_offset,
     int current_history_list_offset,
     int current_history_list_length,
     bool is_view_source,
     bool should_clear_history_list,
-    bool has_user_gesture)
+    NavigationGesture gesture)

[clamy, 2016/11/21 16:50:46]

Since it seems it is both used in RequestNavigationParams &
BeginNavigationParams, could we move it to CommonNavigationParams, which is sent
in all navigation IPCs, instead of having it in two different structs? Thanks!

[Bryan McQuade, 2016/11/22 14:13:03]

Ah, sure, done.

     : is_overriding_user_agent(is_overriding_user_agent),
       redirects(redirects),
       can_load_local_resources(can_load_local_resources),
       page_state(page_state),
       nav_entry_id(nav_entry_id),
       is_same_document_history_load(is_same_document_history_load),
       is_history_navigation_in_new_child(is_history_navigation_in_new_child),
       subframe_unique_names(subframe_unique_names),
       has_committed_real_load(has_committed_real_load),
       intended_as_new_entry(intended_as_new_entry),
       pending_history_list_offset(pending_history_list_offset),
       current_history_list_offset(current_history_list_offset),
       current_history_list_length(current_history_list_length),
       is_view_source(is_view_source),
       should_clear_history_list(should_clear_history_list),
       should_create_service_worker(false),
       service_worker_provider_id(kInvalidServiceWorkerProviderId),
-      has_user_gesture(has_user_gesture) {}
+      gesture(gesture) {}
 
 RequestNavigationParams::RequestNavigationParams(
     const RequestNavigationParams& other) = default;
 
 RequestNavigationParams::~RequestNavigationParams() {
 }
 
 NavigationParams::NavigationParams(
     const CommonNavigationParams& common_params,
     const StartNavigationParams& start_params,
     const RequestNavigationParams& request_params)
     : common_params(common_params),
       start_params(start_params),
       request_params(request_params) {
 }
 
 NavigationParams::~NavigationParams() {
 }
 
 }  // namespace content