Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5061)

Unified Diff: chrome/browser/ssl/security_state_tab_helper.h

Issue 2499243002: Record time to navigation/tab-closed after HTTP-bad warning (Closed)
Patch Set: fix up rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/security_state_tab_helper.h
diff --git a/chrome/browser/ssl/security_state_tab_helper.h b/chrome/browser/ssl/security_state_tab_helper.h
index d91dca4f6042408c8ec47056c4a4de1270b130de..603fb0bd0e6c3db800b9fa201f3a96e9f40401f7 100644
--- a/chrome/browser/ssl/security_state_tab_helper.h
+++ b/chrome/browser/ssl/security_state_tab_helper.h
@@ -36,8 +36,11 @@ class SecurityStateTabHelper
void VisibleSecurityStateChanged();
// content::WebContentsObserver:
+ void DidStartNavigation(
+ content::NavigationHandle* navigation_handle) override;
void DidFinishNavigation(
content::NavigationHandle* navigation_handle) override;
+ void WebContentsDestroyed() override;
private:
explicit SecurityStateTabHelper(content::WebContents* web_contents);
@@ -53,6 +56,13 @@ class SecurityStateTabHelper
// message should only be logged once per main-frame navigation.
bool logged_http_warning_on_current_navigation_;
+ // The time that a console or omnibox warning was shown for insecure
+ // HTTP pages that contain password or credit card fields. This is set
+ // at most once per main-frame navigation (the first that an HTTP
elawrence 2016/11/18 17:43:30 Trivial: Missing word? "the first that" -> "the fi
estark 2016/11/18 23:59:35 Done.
+ // warning triggers on that navigation) and is used for UMA
+ // histogramming.
+ base::Time time_of_http_warning_on_current_navigation_;
+
DISALLOW_COPY_AND_ASSIGN(SecurityStateTabHelper);
};

Powered by Google App Engine
This is Rietveld 408576698