Record time to navigation/tab-closed after HTTP-bad warning

chrome/browser/ssl/security_state_tab_helper_unittest.cc

Index: chrome/browser/ssl/security_state_tab_helper_unittest.cc
diff --git a/chrome/browser/ssl/security_state_tab_helper_unittest.cc b/chrome/browser/ssl/security_state_tab_helper_unittest.cc
index 14cbc89bcdcb5b49c67855a06f4a936bcb775ec2..a20d1ea0b5cae4227d4872a7d4cae6644883ab46 100644
--- a/chrome/browser/ssl/security_state_tab_helper_unittest.cc
+++ b/chrome/browser/ssl/security_state_tab_helper_unittest.cc
@@ -12,6 +12,11 @@
 
 namespace {
 
+const char kHTTPBadNavigationHistogram[] =
+    "Security.HTTPBad.NavigationStartedAfterUserWarnedAboutSensitiveInput";
+const char kHTTPBadWebContentsDestroyedHistogram[] =
+    "Security.HTTPBad.WebContentsDestroyedAfterUserWarnedAboutSensitiveInput";
+
 class SecurityStateTabHelperHistogramTest
     : public ChromeRenderViewHostTestHarness,
       public testing::WithParamInterface<bool> {
@@ -24,11 +29,11 @@ class SecurityStateTabHelperHistogramTest
 
     SecurityStateTabHelper::CreateForWebContents(web_contents());
     helper_ = SecurityStateTabHelper::FromWebContents(web_contents());
-    navigate_to_http();
+    NavigateToHTTP();
   }
 
  protected:
-  void signal_sensitive_input() {
+  void SignalSensitiveInput() {
     if (GetParam())
       web_contents()->OnPasswordInputShownOnHttp();
     else
@@ -43,9 +48,9 @@ class SecurityStateTabHelperHistogramTest
       return "Security.HTTPBad.UserWarnedAboutSensitiveInput.CreditCard";
   }
 
-  void navigate_to_http() { NavigateAndCommit(GURL("http://example.test")); }
+  void NavigateToHTTP() { NavigateAndCommit(GURL("http://example.test")); }
 
-  void navigate_to_different_http_page() {
+  void NavigateToDifferentHTTPPage() {
     NavigateAndCommit(GURL("http://example2.test"));
   }
 
@@ -54,6 +59,76 @@ class SecurityStateTabHelperHistogramTest
   DISALLOW_COPY_AND_ASSIGN(SecurityStateTabHelperHistogramTest);
 };
 
+// Tests that an UMA histogram is recorded after setting the security
+// level to HTTP_SHOW_WARNING and navigating away.
+TEST_P(SecurityStateTabHelperHistogramTest,
+       HTTPOmniboxWarningNavigationHistogram) {
+  base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
+      security_state::switches::kMarkHttpAs,
+      security_state::switches::kMarkHttpWithPasswordsOrCcWithChip);
+
+  base::HistogramTester histograms;
+  SignalSensitiveInput();
+  // Make sure that if the omnibox warning gets dynamically hidden, the
+  // histogram still gets recorded.
+  NavigateToDifferentHTTPPage();
+  if (GetParam())
+    web_contents()->OnAllPasswordInputsHiddenOnHttp();
+  // Destroy the WebContents to simulate the tab being closed after a
+  // navigation.
+  SetContents(nullptr);
+  histograms.ExpectTotalCount(kHTTPBadNavigationHistogram, 1);
+  histograms.ExpectTotalCount(kHTTPBadWebContentsDestroyedHistogram, 0);
+}
+
+// Tests that an UMA histogram is recorded after showing a console
+// warning for a sensitive input on HTTP and navigating away.
+TEST_P(SecurityStateTabHelperHistogramTest,
+       HTTPConsoleWarningNavigationHistogram) {
+  // Same as HTTPOmniboxWarningNavigationHistogram, but ensuring that
+  // the histogram gets recorded even if the command-line switch to show
+  // the omnibox warning is not set.
+  base::HistogramTester histograms;
+  SignalSensitiveInput();
+  NavigateToDifferentHTTPPage();
+  // Destroy the WebContents to simulate the tab being closed after a
+  // navigation.
+  SetContents(nullptr);
+  histograms.ExpectTotalCount(kHTTPBadNavigationHistogram, 1);
+  histograms.ExpectTotalCount(kHTTPBadWebContentsDestroyedHistogram, 0);
+}
+
+// Tests that an UMA histogram is recorded after setting the security
+// level to HTTP_SHOW_WARNING and closing the tab.
+TEST_P(SecurityStateTabHelperHistogramTest,
+       HTTPOmniboxWarningTabClosedHistogram) {
+  base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
+      security_state::switches::kMarkHttpAs,
+      security_state::switches::kMarkHttpWithPasswordsOrCcWithChip);
+
+  base::HistogramTester histograms;
+  SignalSensitiveInput();
+  // Destroy the WebContents to simulate the tab being closed.
+  SetContents(nullptr);
+  histograms.ExpectTotalCount(kHTTPBadNavigationHistogram, 0);
+  histograms.ExpectTotalCount(kHTTPBadWebContentsDestroyedHistogram, 1);
+}
+
+// Tests that an UMA histogram is recorded after showing a console
+// warning for a sensitive input on HTTP and closing the tab.
+TEST_P(SecurityStateTabHelperHistogramTest,
+       HTTPConsoleWarningTabClosedHistogram) {
+  // Same as HTTPOmniboxWarningTabClosedHistogram, but ensuring that the
+  // histogram gets recorded even if the command-line switch to show the
+  // omnibox warning is not set.

[elawrence, 2016/11/18 17:43:30]

Do we need to explicitly write out the flag state we want for
security_state::switches::kMarkHttpAs, to account for the fact that the default
state of this flag will change later in 2017?

[estark, 2016/11/18 23:59:35]

Oops, sorry, lost that in the rebase too. :( Done.

+  base::HistogramTester histograms;
+  SignalSensitiveInput();
+  // Destroy the WebContents to simulate the tab being closed.
+  SetContents(nullptr);
+  histograms.ExpectTotalCount(kHTTPBadNavigationHistogram, 0);
+  histograms.ExpectTotalCount(kHTTPBadWebContentsDestroyedHistogram, 1);
+}
+
 // Tests that UMA logs the omnibox warning when security level is
 // HTTP_SHOW_WARNING.
 TEST_P(SecurityStateTabHelperHistogramTest, HTTPOmniboxWarningHistogram) {
@@ -63,17 +138,17 @@ TEST_P(SecurityStateTabHelperHistogramTest, HTTPOmniboxWarningHistogram) {
       security_state::switches::kMarkHttpWithPasswordsOrCcWithChip);
 
   base::HistogramTester histograms;
-  signal_sensitive_input();
+  SignalSensitiveInput();
   histograms.ExpectUniqueSample(histogram_name(), true, 1);
 
   // Fire again and ensure no sample is recorded.
-  signal_sensitive_input();
+  SignalSensitiveInput();
   histograms.ExpectUniqueSample(histogram_name(), true, 1);
 
   // Navigate to a new page and ensure a sample is recorded.
-  navigate_to_different_http_page();
+  NavigateToDifferentHTTPPage();
   histograms.ExpectUniqueSample(histogram_name(), true, 1);
-  signal_sensitive_input();
+  SignalSensitiveInput();
   histograms.ExpectUniqueSample(histogram_name(), true, 2);
 }
 
@@ -85,17 +160,17 @@ TEST_P(SecurityStateTabHelperHistogramTest, HTTPConsoleWarningHistogram) {
       security_state::switches::kMarkHttpAsNeutral);
 
   base::HistogramTester histograms;
-  signal_sensitive_input();
+  SignalSensitiveInput();
   histograms.ExpectUniqueSample(histogram_name(), false, 1);
 
   // Fire again and ensure no sample is recorded.
-  signal_sensitive_input();
+  SignalSensitiveInput();
   histograms.ExpectUniqueSample(histogram_name(), false, 1);
 
   // Navigate to a new page and ensure a sample is recorded.
-  navigate_to_different_http_page();
+  NavigateToDifferentHTTPPage();
   histograms.ExpectUniqueSample(histogram_name(), false, 1);
-  signal_sensitive_input();
+  SignalSensitiveInput();
   histograms.ExpectUniqueSample(histogram_name(), false, 2);
 }