Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Unified Diff: content/renderer/render_frame_proxy.h

Issue 2499053003: Simplify RenderFrameImpl::ResolveOpener() (Closed)
Patch Set: Rebase. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/renderer/render_frame_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_proxy.h
diff --git a/content/renderer/render_frame_proxy.h b/content/renderer/render_frame_proxy.h
index 280bf3f7ad2ec1aa3ca635135f67d9e5e0fec168..e7f2e54377778a5168b6494f00e08e8c84972b70 100644
--- a/content/renderer/render_frame_proxy.h
+++ b/content/renderer/render_frame_proxy.h
@@ -77,10 +77,9 @@ class CONTENT_EXPORT RenderFrameProxy
// for example, after a cross-process navigation or after the addition of a
// new frame local to some other process. |routing_id| will be the ID of the
// newly created RenderFrameProxy. |render_view_routing_id| identifies the
- // RenderView to be associated with this frame. |opener_routing_id|, if
- // valid, is the routing ID of the new frame's opener. |parent_routing_id|
- // is the routing ID of the RenderFrameProxy to which the new frame is
- // parented.
+ // RenderView to be associated with this frame. |opener|, if supplied, is the
+ // new frame's opener. |parent_routing_id| is the routing ID of the
+ // RenderFrameProxy to which the new frame is parented.
//
// |parent_routing_id| always identifies a RenderFrameProxy (never a
// RenderFrame) because a new child of a local frame should always start out
@@ -88,7 +87,7 @@ class CONTENT_EXPORT RenderFrameProxy
static RenderFrameProxy* CreateFrameProxy(
int routing_id,
int render_view_routing_id,
- int opener_routing_id,
+ blink::WebFrame* opener,
int parent_routing_id,
const FrameReplicationState& replicated_state);
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/renderer/render_frame_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698