Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8732)

Unified Diff: components/sessions/core/session_types.cc

Issue 2499023004: [Sync] Introduce SyncedSessionWindow type. (Closed)
Patch Set: Fix compile Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sessions/core/session_types.cc
diff --git a/components/sessions/core/session_types.cc b/components/sessions/core/session_types.cc
index db020bf0b83a5ebcafece72223c4cbc8bce20824..4b7ced980ca47c959cbd8d2614568f536f460c77 100644
--- a/components/sessions/core/session_types.cc
+++ b/components/sessions/core/session_types.cc
@@ -39,9 +39,6 @@ void SessionTab::SetFromSyncData(const sync_pb::SessionTab& sync_data,
SerializedNavigationEntry::FromSyncData(i, sync_data.navigation(i)));
}
session_storage_persistent_id.clear();
- variation_ids.clear();
- for (int i = 0; i < sync_data.variation_id_size(); ++i)
- variation_ids.push_back(sync_data.variation_id(i));
}
sync_pb::SessionTab SessionTab::ToSyncData() const {
@@ -55,9 +52,6 @@ sync_pb::SessionTab SessionTab::ToSyncData() const {
for (const SerializedNavigationEntry& navigation : navigations) {
*sync_data.add_navigation() = navigation.ToSyncData();
}
- for (const variations::VariationID variation_id : variation_ids) {
- sync_data.add_variation_id(variation_id);
- }
return sync_data;
}
@@ -71,27 +65,4 @@ SessionWindow::SessionWindow()
SessionWindow::~SessionWindow() {}
-sync_pb::SessionWindow SessionWindow::ToSyncData() const {
- sync_pb::SessionWindow sync_data;
- sync_data.set_window_id(window_id.id());
- sync_data.set_selected_tab_index(selected_tab_index);
- switch (type) {
- case SessionWindow::TYPE_TABBED:
- sync_data.set_browser_type(
- sync_pb::SessionWindow_BrowserType_TYPE_TABBED);
- break;
- case SessionWindow::TYPE_POPUP:
- sync_data.set_browser_type(
- sync_pb::SessionWindow_BrowserType_TYPE_POPUP);
- break;
- default:
- NOTREACHED() << "Unhandled browser type.";
- }
-
- for (const auto& tab : tabs)
- sync_data.add_tab(tab->tab_id.id());
-
- return sync_data;
-}
-
} // namespace sessions

Powered by Google App Engine
This is Rietveld 408576698