Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Unified Diff: components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc

Issue 2499023004: [Sync] Introduce SyncedSessionWindow type. (Closed)
Patch Set: Fix compile Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc
diff --git a/components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc b/components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc
index 571ca6e1b0bd2134c371b674a7715ad0c3ef31b7..985487def9a85189587fdc8f351a5619c138621c 100644
--- a/components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc
+++ b/components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc
@@ -34,6 +34,7 @@ using base::TimeDelta;
using sessions::SerializedNavigationEntry;
using sessions::SessionTab;
using sessions::SessionWindow;
+using sync_sessions::SyncedSessionWindow;
using sync_sessions::SyncedSession;
using DismissedFilter = base::Callback<bool(const std::string& id)>;
@@ -366,9 +367,10 @@ ForeignSessionsSuggestionsProvider::GetSuggestionCandidates(
std::vector<SessionData> suggestion_candidates;
for (const SyncedSession* session : foreign_sessions) {
for (const std::pair<const SessionID::id_type,
Patrick Noland 2017/03/28 20:42:00 [nit] This would be a little less verbose with aut
Nicolas Zea 2017/03/29 19:01:33 Done.
- std::unique_ptr<sessions::SessionWindow>>& key_value :
+ std::unique_ptr<SyncedSessionWindow>>& key_value :
session->windows) {
- for (const std::unique_ptr<SessionTab>& tab : key_value.second->tabs) {
+ for (const std::unique_ptr<SessionTab>& tab :
+ key_value.second->wrapped_window.tabs) {
if (tab->navigations.empty()) {
continue;
}

Powered by Google App Engine
This is Rietveld 408576698