Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: third_party/WebKit/Source/core/paint/BoxPaintInvalidator.h

Issue 2498823002: Paint invalidation of local attachment backgrounds (Closed)
Patch Set: - Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/BoxPaintInvalidator.h
diff --git a/third_party/WebKit/Source/core/paint/BoxPaintInvalidator.h b/third_party/WebKit/Source/core/paint/BoxPaintInvalidator.h
index 872821e9ff64cf68a5a8449d3516379bdb516461..1a167227ce3ef4418c8752ec24bb3860449b63c0 100644
--- a/third_party/WebKit/Source/core/paint/BoxPaintInvalidator.h
+++ b/third_party/WebKit/Source/core/paint/BoxPaintInvalidator.h
@@ -28,13 +28,21 @@ class BoxPaintInvalidator {
PaintInvalidationReason invalidatePaintIfNeeded();
private:
+ bool backgroundGeometryDependsOnLayoutOverflowRect();
+ bool backgroundPaintsOntoScrollingContentsLayer();
+ bool shouldFullyInvalidateBackgroundOnLayoutOverflowChange(const LayoutRect&,
chrishtr 2016/11/17 20:42:36 Document these two arguments
Xianzhu 2016/11/17 23:36:41 Done.
+ const LayoutRect&);
+ void invalidateScrollingContentsBackgroundIfNeeded();
+
PaintInvalidationReason computePaintInvalidationReason();
- bool incrementallyInvalidatePaint();
+ bool incrementallyInvalidatePaint(PaintInvalidationReason,
+ const LayoutRect& oldRect,
+ const LayoutRect& newRect);
bool needsToSavePreviousBoxGeometries();
void savePreviousBoxGeometriesIfNeeded();
- LayoutSize previousBorderBoxSize(const LayoutSize& previousVisualRectSize);
+ LayoutSize previousBorderBoxSize();
LayoutRect previousContentBoxRect();
LayoutRect previousLayoutOverflowRect();

Powered by Google App Engine
This is Rietveld 408576698