third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp - Issue 2498823002: Paint invalidation of local attachment backgrounds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

Issue 2498823002: Paint invalidation of local attachment backgrounds (Closed)

Patch Set: - Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/overflow-scroll-local-background-text-color-change-expected.txt ('k') | third_party/WebKit/Source/core/paint/BoxPaintInvalidator.h » ('j') | third_party/WebKit/Source/core/paint/BoxPaintInvalidator.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

index ebe400f573dabc4f76ab52aa00f487e94387c851..ad71c1d49dff4bbe08fd965248f64ae7acd774a3 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

@@ -1258,8 +1258,7 @@ void CompositedLayerMapping::updateScrollingLayerGeometry(

IntSize scrollSize(layoutBox->pixelSnappedScrollWidth(),

layoutBox->pixelSnappedScrollHeight());

- if (scrollSize != m_scrollingContentsLayer->size() ||

chrishtr 2016/11/17 20:42:36 Why this change?

Xianzhu 2016/11/17 23:36:41 This fully invalidated the scrolling contents laye

- overflowClipRectOffsetChanged)

+ if (overflowClipRectOffsetChanged)

m_scrollingContentsLayer->setNeedsDisplay();

DoubleSize scrollingContentsOffset(