Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

Issue 2498823002: Paint invalidation of local attachment backgrounds (Closed)
Patch Set: - Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2010, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2009, 2010, 2011 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 1240 matching lines...) Expand 10 before | Expand all | Expand 10 after
1251 m_childClippingMaskLayer->setSize(m_scrollingLayer->size()); 1251 m_childClippingMaskLayer->setSize(m_scrollingLayer->size());
1252 m_childClippingMaskLayer->setOffsetFromLayoutObject( 1252 m_childClippingMaskLayer->setOffsetFromLayoutObject(
1253 toIntSize(overflowClipRect.location())); 1253 toIntSize(overflowClipRect.location()));
1254 } 1254 }
1255 1255
1256 bool overflowClipRectOffsetChanged = 1256 bool overflowClipRectOffsetChanged =
1257 oldScrollingLayerOffset != m_scrollingLayer->offsetFromLayoutObject(); 1257 oldScrollingLayerOffset != m_scrollingLayer->offsetFromLayoutObject();
1258 1258
1259 IntSize scrollSize(layoutBox->pixelSnappedScrollWidth(), 1259 IntSize scrollSize(layoutBox->pixelSnappedScrollWidth(),
1260 layoutBox->pixelSnappedScrollHeight()); 1260 layoutBox->pixelSnappedScrollHeight());
1261 if (scrollSize != m_scrollingContentsLayer->size() || 1261 if (overflowClipRectOffsetChanged)
chrishtr 2016/11/17 20:42:36 Why this change?
Xianzhu 2016/11/17 23:36:41 This fully invalidated the scrolling contents laye
1262 overflowClipRectOffsetChanged)
1263 m_scrollingContentsLayer->setNeedsDisplay(); 1262 m_scrollingContentsLayer->setNeedsDisplay();
1264 1263
1265 DoubleSize scrollingContentsOffset( 1264 DoubleSize scrollingContentsOffset(
1266 overflowClipRect.location().x() - scrollPosition.x(), 1265 overflowClipRect.location().x() - scrollPosition.x(),
1267 overflowClipRect.location().y() - scrollPosition.y()); 1266 overflowClipRect.location().y() - scrollPosition.y());
1268 // The scroll offset change is compared using floating point so that 1267 // The scroll offset change is compared using floating point so that
1269 // fractional scroll offset change can be propagated to compositor. 1268 // fractional scroll offset change can be propagated to compositor.
1270 if (scrollingContentsOffset != m_scrollingContentsOffset || 1269 if (scrollingContentsOffset != m_scrollingContentsOffset ||
1271 scrollSize != m_scrollingContentsLayer->size()) { 1270 scrollSize != m_scrollingContentsLayer->size()) {
1272 bool coordinatorHandlesOffset = 1271 bool coordinatorHandlesOffset =
(...skipping 1978 matching lines...) Expand 10 before | Expand all | Expand 10 after
3251 } else if (graphicsLayer == m_scrollingContentsLayer.get()) { 3250 } else if (graphicsLayer == m_scrollingContentsLayer.get()) {
3252 name = "Scrolling Contents Layer"; 3251 name = "Scrolling Contents Layer";
3253 } else { 3252 } else {
3254 ASSERT_NOT_REACHED(); 3253 ASSERT_NOT_REACHED();
3255 } 3254 }
3256 3255
3257 return name; 3256 return name;
3258 } 3257 }
3259 3258
3260 } // namespace blink 3259 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698