Remove some global UI defines

Remove some global UI defines

Remove the USE_CLIPBOARD_AURAX11 C++ define which were unused. The use_clipboard_aurax11 build variable was only used in one place (ui/base/BUILD.gn) and seems not to be useful. This is replaced by a "use_x11 && is_desktop_linux" condition.

Remove the enable_clipboard_aurax11 build arg which affected the use_ variant above and is no longer needed.

Move USE_DEFAULT_RENDER_THEME build variable and C++ define to Blink's public features.

Committed: https://crrev.com/8a274fa60fec11c1c1ddbeb2ee64c3ffb60ca84c
Cr-Commit-Position: refs/heads/master@{#432010}

[brettw, 2016-11-11 20:44:34]

Description was changed from

==========
Move default_render_theme build flag to WebKit
==========

to

==========
Remove some global UI defines

Remove the USE_CLIPBOARD_AURAX11 C++ define which were unused. The
use_clipboard_aurax11 build variable was only used in one place
(ui/base/BUILD.gn) and seems not to be useful. This is replaced by a "use_x11 &&
is_desktop_linux" condition.

Remove the enable_clipboard_aurax11 build arg which affected the use_ variant
above and is no longer needed.

Move USE_DEFAULT_RENDER_THEME build variable and C++ define to Blink's public
features.
==========

[brettw, 2016-11-11 20:44:34]

brettw@chromium.org changed reviewers:
+ sky@chromium.org

[brettw, 2016-11-11 20:44:40]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 20:45:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 22:46:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 22:46:42]

Dry run: Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2016-11-12 00:15:47]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-12 00:16:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-12 00:22:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-12 00:22:30]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[brettw, 2016-11-14 16:40:40]

Merge

[brettw, 2016-11-14 16:40:40]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 16:41:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 19:44:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 19:44:26]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[brettw, 2016-11-14 20:08:48]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 20:13:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-11-14 22:22:45]

LGTM

[brettw, 2016-11-14 22:23:05]

The CQ bit was unchecked by brettw@chromium.org

[brettw, 2016-11-14 22:23:09]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-11-14 22:24:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 00:21:10]

Description was changed from

==========
Remove some global UI defines

Remove the USE_CLIPBOARD_AURAX11 C++ define which were unused. The
use_clipboard_aurax11 build variable was only used in one place
(ui/base/BUILD.gn) and seems not to be useful. This is replaced by a "use_x11 &&
is_desktop_linux" condition.

Remove the enable_clipboard_aurax11 build arg which affected the use_ variant
above and is no longer needed.

Move USE_DEFAULT_RENDER_THEME build variable and C++ define to Blink's public
features.
==========

to

==========
Remove some global UI defines

Remove the USE_CLIPBOARD_AURAX11 C++ define which were unused. The
use_clipboard_aurax11 build variable was only used in one place
(ui/base/BUILD.gn) and seems not to be useful. This is replaced by a "use_x11 &&
is_desktop_linux" condition.

Remove the enable_clipboard_aurax11 build arg which affected the use_ variant
above and is no longer needed.

Move USE_DEFAULT_RENDER_THEME build variable and C++ define to Blink's public
features.
==========

[commit-bot: I haz the power, 2016-11-15 00:21:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-15 00:23:44]

Description was changed from

==========
Remove some global UI defines

Remove the USE_CLIPBOARD_AURAX11 C++ define which were unused. The
use_clipboard_aurax11 build variable was only used in one place
(ui/base/BUILD.gn) and seems not to be useful. This is replaced by a "use_x11 &&
is_desktop_linux" condition.

Remove the enable_clipboard_aurax11 build arg which affected the use_ variant
above and is no longer needed.

Move USE_DEFAULT_RENDER_THEME build variable and C++ define to Blink's public
features.
==========

to

==========
Remove some global UI defines

Remove the USE_CLIPBOARD_AURAX11 C++ define which were unused. The
use_clipboard_aurax11 build variable was only used in one place
(ui/base/BUILD.gn) and seems not to be useful. This is replaced by a "use_x11 &&
is_desktop_linux" condition.

Remove the enable_clipboard_aurax11 build arg which affected the use_ variant
above and is no longer needed.

Move USE_DEFAULT_RENDER_THEME build variable and C++ define to Blink's public
features.

Committed: https://crrev.com/8a274fa60fec11c1c1ddbeb2ee64c3ffb60ca84c
Cr-Commit-Position: refs/heads/master@{#432010}
==========

[commit-bot: I haz the power, 2016-11-15 00:23:45]

Patchset 2 (id:??) landed as
https://crrev.com/8a274fa60fec11c1c1ddbeb2ee64c3ffb60ca84c
Cr-Commit-Position: refs/heads/master@{#432010}

[oshima, 2017-01-05 21:22:11]

oshima@chromium.org changed reviewers:
+ oshima@chromium.org

[oshima, 2017-01-05 21:22:12]

use_clipboard_aurax11 build is used by a few chromeos developers. It's handy to
be able to cut&paste between x11 and chrome for chrome on linux desktop.

Is it ok to restore this flag?