Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1614)

Issue 2498613004: [System Health] Reenable tests failing due to bug in ScrollToElement (Closed)

Created:
4 years, 1 month ago by rnephew (Reviews Here)
Modified:
4 years, 1 month ago
Reviewers:
perezju, nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[System Health] Reenable tests failing due to bug in ScrollToElement Fix is landing in: https://codereview.chromium.org/2497023002/ BUG=664518 Committed: https://crrev.com/38c2eac67d10cd0a519f2e76b2b0287d283c0454 Cr-Commit-Position: refs/heads/master@{#431693}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M tools/perf/page_sets/system_health/browsing_stories.py View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
rnephew (Reviews Here)
4 years, 1 month ago (2016-11-11 21:31:26 UTC) #2
nednguyen
lgtm Thanks for the quick fix, Randy!
4 years, 1 month ago (2016-11-11 21:32:30 UTC) #4
nednguyen
On 2016/11/11 21:32:30, nednguyen wrote: > lgtm > > Thanks for the quick fix, Randy! ...
4 years, 1 month ago (2016-11-11 21:36:08 UTC) #6
rnephew (Reviews Here)
On 2016/11/11 21:36:08, nednguyen wrote: > On 2016/11/11 21:32:30, nednguyen wrote: > > lgtm > ...
4 years, 1 month ago (2016-11-11 21:52:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2498613004/20001
4 years, 1 month ago (2016-11-11 22:06:55 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-12 00:19:31 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-12 00:23:41 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/38c2eac67d10cd0a519f2e76b2b0287d283c0454
Cr-Commit-Position: refs/heads/master@{#431693}

Powered by Google App Engine
This is Rietveld 408576698