Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2493203002:
Reenable system health smoke tests that were disabled because they took too long. (Closed)
DescriptionReenable system health smoke tests that were disabled because they took too long.
BUG=664518, 660608
Committed: https://crrev.com/8b8aefd36998a2e90cdc58b509df4702fc61f3e5
Cr-Commit-Position: refs/heads/master@{#431653}
Patch Set 1 #
Messages
Total messages: 28 (15 generated)
The CQ bit was checked by nednguyen@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Reenable system health smoke tests that were disabled because they took too long. BUG=664518 ========== to ========== Reenable system health smoke tests that were disabled because they took too long. BUG=664518 ==========
nednguyen@google.com changed reviewers: + perezju@chromium.org
Description was changed from ========== Reenable system health smoke tests that were disabled because they took too long. BUG=664518 ========== to ========== Reenable system health smoke tests that were disabled because they took too long. BUG=664518, 660608 ==========
Do we really wan't to re-enable all of these now? For example for the browse stories I've just disabled, maybe both the smoke and regular versions of the stories should be re-enabled together?
On 2016/11/11 16:12:31, perezju wrote: > Do we really wan't to re-enable all of these now? > > For example for the browse stories I've just disabled, maybe both the smoke and > regular versions of the stories should be re-enabled together? It's ok as long as the CQ has passed. Part of me making this CL is to see which one are failing on CQ right now.
On 2016/11/11 16:14:54, nednguyen wrote: > On 2016/11/11 16:12:31, perezju wrote: > > Do we really wan't to re-enable all of these now? > > > > For example for the browse stories I've just disabled, maybe both the smoke > and > > regular versions of the stories should be re-enabled together? > > It's ok as long as the CQ has passed. Part of me making this CL is to see which > one are failing on CQ right now. Take into account that some of the stories (on some devices) do not fail consistently but only flake.
On 2016/11/11 16:23:19, perezju wrote: > On 2016/11/11 16:14:54, nednguyen wrote: > > On 2016/11/11 16:12:31, perezju wrote: > > > Do we really wan't to re-enable all of these now? > > > > > > For example for the browse stories I've just disabled, maybe both the smoke > > and > > > regular versions of the stories should be re-enabled together? > > > > It's ok as long as the CQ has passed. Part of me making this CL is to see > which > > one are failing on CQ right now. > > Take into account that some of the stories (on some devices) do not fail > consistently but only flake. With the work in https://bugs.chromium.org/p/chromium/issues/detail?id=649762, we will be able to track individual flaky test failures & disable them as soon as they pop up.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by nednguyen@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/11/11 16:25:14, nednguyen wrote: > On 2016/11/11 16:23:19, perezju wrote: > > On 2016/11/11 16:14:54, nednguyen wrote: > > > On 2016/11/11 16:12:31, perezju wrote: > > > > Do we really wan't to re-enable all of these now? > > > > > > > > For example for the browse stories I've just disabled, maybe both the > smoke > > > and > > > > regular versions of the stories should be re-enabled together? > > > > > > It's ok as long as the CQ has passed. Part of me making this CL is to see > > which > > > one are failing on CQ right now. > > > > Take into account that some of the stories (on some devices) do not fail > > consistently but only flake. > > With the work in https://bugs.chromium.org/p/chromium/issues/detail?id=649762, > we will be able to track individual flaky test failures & disable them as soon > as they pop up. It's all green now, PTAL
nednguyen@google.com changed reviewers: + jbudorick@chromium.org, stip@chromium.org
On 2016/11/11 20:57:07, nednguyen wrote: > On 2016/11/11 16:25:14, nednguyen wrote: > > On 2016/11/11 16:23:19, perezju wrote: > > > On 2016/11/11 16:14:54, nednguyen wrote: > > > > On 2016/11/11 16:12:31, perezju wrote: > > > > > Do we really wan't to re-enable all of these now? > > > > > > > > > > For example for the browse stories I've just disabled, maybe both the > > smoke > > > > and > > > > > regular versions of the stories should be re-enabled together? > > > > > > > > It's ok as long as the CQ has passed. Part of me making this CL is to see > > > which > > > > one are failing on CQ right now. > > > > > > Take into account that some of the stories (on some devices) do not fail > > > consistently but only flake. > > > > With the work in https://bugs.chromium.org/p/chromium/issues/detail?id=649762, > > we will be able to track individual flaky test failures & disable them as soon > > as they pop up. > > It's all green now, PTAL +John & Mike because this bumps up the test time of telemetry_perf_unittest on android_nexus_5x to 9m 31s
lgtm as long as they only run on the N5X bots
On 2016/11/11 21:32:22, stip wrote: > lgtm as long as they only run on the N5X bots Yes, telemetry_perf_unittest in linux_chromium_rel_ng is still taking 2m 36s (https://chromium-swarm.appspot.com/task?id=326ceb8f7aa6b210&refresh=10&show_r...)
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/11/11 21:34:04, nednguyen wrote: > On 2016/11/11 21:32:22, stip wrote: > > lgtm as long as they only run on the N5X bots > > Yes, telemetry_perf_unittest in linux_chromium_rel_ng is still taking 2m 36s > (https://chromium-swarm.appspot.com/task?id=326ceb8f7aa6b210&refresh=10&show_r...) Err, I meant linux_android_rel_ng
Message was sent while issue was closed.
Description was changed from ========== Reenable system health smoke tests that were disabled because they took too long. BUG=664518, 660608 ========== to ========== Reenable system health smoke tests that were disabled because they took too long. BUG=664518, 660608 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Reenable system health smoke tests that were disabled because they took too long. BUG=664518, 660608 ========== to ========== Reenable system health smoke tests that were disabled because they took too long. BUG=664518, 660608 Committed: https://crrev.com/8b8aefd36998a2e90cdc58b509df4702fc61f3e5 Cr-Commit-Position: refs/heads/master@{#431653} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/8b8aefd36998a2e90cdc58b509df4702fc61f3e5 Cr-Commit-Position: refs/heads/master@{#431653} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
