Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: impl/memory/datastore.go

Issue 2498463003: Fix a bug where deletions weren't updating the raw Kind index. (Closed)
Patch Set: impl/memory: query limits/offsets count deleted Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: impl/memory/datastore.go
diff --git a/impl/memory/datastore.go b/impl/memory/datastore.go
index c01b4d4120a9f547e5de0d9675524ddc3f9198ee..677264634738ffc7b1141a66f11f01480442deab 100644
--- a/impl/memory/datastore.go
+++ b/impl/memory/datastore.go
@@ -92,10 +92,10 @@ func (d *dsImpl) DecodeCursor(s string) (ds.Cursor, error) {
func (d *dsImpl) Run(fq *ds.FinalizedQuery, cb ds.RawRunCB) error {
idx, head := d.data.getQuerySnaps(!fq.EventuallyConsistent())
- err := executeQuery(fq, d.kc, false, idx, head, cb)
+ err := executeQuery(fq, d.kc, false, false, idx, head, cb)
if d.data.maybeAutoIndex(err) {
idx, head = d.data.getQuerySnaps(!fq.EventuallyConsistent())
- err = executeQuery(fq, d.kc, false, idx, head, cb)
+ err = executeQuery(fq, d.kc, false, false, idx, head, cb)
}
return err
}
@@ -207,7 +207,7 @@ func (d *txnDsImpl) Run(q *ds.FinalizedQuery, cb ds.RawRunCB) error {
// It's possible that if you have full-consistency and also auto index enabled
// that this would make sense... but at that point you should probably just
// add the index up front.
- return executeQuery(q, d.kc, true, d.data.snap, d.data.snap, cb)
+ return executeQuery(q, d.kc, true, false, d.data.snap, d.data.snap, cb)
}
func (d *txnDsImpl) Count(fq *ds.FinalizedQuery) (ret int64, err error) {
@@ -219,7 +219,7 @@ func (*txnDsImpl) RunInTransaction(func(c context.Context) error, *ds.Transactio
}
func (d *txnDsImpl) WithoutTransaction() context.Context {
- return context.WithValue(d, currentTxnKey, nil)
+ return context.WithValue(d, &currentTxnKey, nil)
}
func (d *txnDsImpl) CurrentTransaction() ds.Transaction {

Powered by Google App Engine
This is Rietveld 408576698