Fix a bug where deletions weren't updating the raw Kind index.

impl/memory/datastore.go

 // Copyright 2015 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package memory
 
 import (
         "errors"
         "fmt"
 
@@ skipping 74 matching lines @@
         d.data.delMulti(keys, cb)
         return nil
 }
 
 func (d *dsImpl) DecodeCursor(s string) (ds.Cursor, error) {
         return newCursor(s)
 }
 
 func (d *dsImpl) Run(fq *ds.FinalizedQuery, cb ds.RawRunCB) error {
         idx, head := d.data.getQuerySnaps(!fq.EventuallyConsistent())
-        err := executeQuery(fq, d.kc, false, idx, head, cb)
+        err := executeQuery(fq, d.kc, false, false, idx, head, cb)
         if d.data.maybeAutoIndex(err) {
                 idx, head = d.data.getQuerySnaps(!fq.EventuallyConsistent())
-                err = executeQuery(fq, d.kc, false, idx, head, cb)
+                err = executeQuery(fq, d.kc, false, false, idx, head, cb)
         }
         return err
 }
 
 func (d *dsImpl) Count(fq *ds.FinalizedQuery) (ret int64, err error) {
         idx, head := d.data.getQuerySnaps(!fq.EventuallyConsistent())
         ret, err = countQuery(fq, d.kc, false, idx, head)
         if d.data.maybeAutoIndex(err) {
                 idx, head := d.data.getQuerySnaps(!fq.EventuallyConsistent())
                 ret, err = countQuery(fq, d.kc, false, idx, head)
@@ skipping 91 matching lines @@
 func (d *txnDsImpl) Run(q *ds.FinalizedQuery, cb ds.RawRunCB) error {
         // note that autoIndex has no effect inside transactions. This is because
         // the transaction guarantees a consistent view of head at the time that the
         // transaction opens. At best, we could add the index on head, but then return
         // the error anyway, but adding the index then re-snapping at head would
         // potentially reveal other entities not in the original transaction snapshot.
         //
         // It's possible that if you have full-consistency and also auto index enabled
         // that this would make sense... but at that point you should probably just
         // add the index up front.
-        return executeQuery(q, d.kc, true, d.data.snap, d.data.snap, cb)
+        return executeQuery(q, d.kc, true, false, d.data.snap, d.data.snap, cb)
 }
 
 func (d *txnDsImpl) Count(fq *ds.FinalizedQuery) (ret int64, err error) {
         return countQuery(fq, d.kc, true, d.data.snap, d.data.snap)
 }
 
 func (*txnDsImpl) RunInTransaction(func(c context.Context) error, *ds.TransactionOptions) error {
         return errors.New("datastore: nested transactions are not supported")
 }
 
 func (d *txnDsImpl) WithoutTransaction() context.Context {
-        return context.WithValue(d, currentTxnKey, nil)
+        return context.WithValue(d, &currentTxnKey, nil)
 }
 
 func (d *txnDsImpl) CurrentTransaction() ds.Transaction {
         return d.data.txn
 }
 
 func (d *txnDsImpl) GetTestable() ds.Testable { return nil }