Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 2498433002: Revert of Expose GlobalRequestID in NavigationHandle and ResourceRequestInfo. (Closed)

Created:
4 years, 1 month ago by Dirk Pranke
Modified:
4 years, 1 month ago
CC:
chromium-reviews, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, Randy Smith (Not in Mondays), darin-cc_chromium.org, loading-reviews_chromium.org, mmenke, Charlie Reis, nasko
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Expose GlobalRequestID in NavigationHandle and ResourceRequestInfo. (patchset #14 id:400001 of https://codereview.chromium.org/2413663003/ ) Reason for revert: Looks like this is causing a test to crash on Win7 debug: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/54581 https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/54581/steps/browser_tests%20on%20Windows-7-SP1/logs/PrerenderBrowserTestWithExtensions.StreamsTest So I'm reverting it, after double-checking w/ ryansturm@. Sorry! Original issue's description: > Expose GlobalRequestID in NavigationHandle and ResourceRequestInfo. > > Create DataUseRecorder instances associated with page loads. > Instances are associated with either pending navigations or render > frame hosts depending on the state of the page load. Use > GlobalRequestID to associate MAIN_FRAME URLRequests with their > corresponding pending navigation. Complete life-cycle of the > DataUseRecorders will be implemented in a forthcoming cl. > > BUG=660065 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Committed: https://crrev.com/763c3fe382f8ae7c39cfa28191eab55b1036e4e6 > Cr-Commit-Position: refs/heads/master@{#431282} TBR=clamy@chromium.org,rajendrant@chromium.org,ryansturm@chromium.org,kundaji@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=660065 Committed: https://crrev.com/093c9fbda78ab82fd22e1b0c0ae94942eff2660b Cr-Commit-Position: refs/heads/master@{#431368}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -251 lines) Patch
M chrome/browser/data_use_measurement/chrome_data_use_ascriber.h View 4 chunks +7 lines, -75 lines 0 comments Download
M chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc View 6 chunks +1 line, -122 lines 0 comments Download
M chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.h View 2 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc View 4 chunks +20 lines, -3 lines 0 comments Download
M chrome/browser/data_use_measurement/data_use_web_contents_observer.h View 1 chunk +11 lines, -2 lines 0 comments Download
M chrome/browser/data_use_measurement/data_use_web_contents_observer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/navigation_handle_impl.h View 3 chunks +9 lines, -5 lines 0 comments Download
M content/browser/frame_host/navigation_handle_impl.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 5 chunks +4 lines, -7 lines 0 comments Download
M content/browser/loader/resource_request_info_impl.h View 3 chunks +1 line, -2 lines 0 comments Download
M content/browser/loader/resource_request_info_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/public/browser/navigation_handle.h View 3 chunks +0 lines, -10 lines 0 comments Download
M content/public/browser/resource_request_info.h View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Dirk Pranke
Created Revert of Expose GlobalRequestID in NavigationHandle and ResourceRequestInfo.
4 years, 1 month ago (2016-11-10 21:48:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2498433002/1
4 years, 1 month ago (2016-11-10 21:49:17 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 21:51:37 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 23:09:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/093c9fbda78ab82fd22e1b0c0ae94942eff2660b
Cr-Commit-Position: refs/heads/master@{#431368}

Powered by Google App Engine
This is Rietveld 408576698