Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(880)

Unified Diff: chrome/browser/data_use_measurement/data_use_web_contents_observer.h

Issue 2498433002: Revert of Expose GlobalRequestID in NavigationHandle and ResourceRequestInfo. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/data_use_measurement/data_use_web_contents_observer.h
diff --git a/chrome/browser/data_use_measurement/data_use_web_contents_observer.h b/chrome/browser/data_use_measurement/data_use_web_contents_observer.h
index 978ec4733b5f1299a239d25e0171ab868fe4d0ef..308b3b521ec0c10846ec29a8fadfdf9e9166e6b1 100644
--- a/chrome/browser/data_use_measurement/data_use_web_contents_observer.h
+++ b/chrome/browser/data_use_measurement/data_use_web_contents_observer.h
@@ -32,13 +32,22 @@
~DataUseWebContentsObserver() override;
- // WebContentsObserver implementation:
+ // WebContentsObserver:
+ // Called when a render frame host is created.
void RenderFrameCreated(content::RenderFrameHost* render_frame_host) override;
+
+ // Called when a render frame host is deleted.
void RenderFrameDeleted(content::RenderFrameHost* render_frame_host) override;
+
+ // Called when a navigation is started.
void DidStartNavigation(
content::NavigationHandle* navigation_handle) override;
- void ReadyToCommitNavigation(
+
+ // Called when a navigation is completed.
+ void DidFinishNavigation(
content::NavigationHandle* navigation_handle) override;
+
+ // Called when a navigation is redirected.
void DidRedirectNavigation(
content::NavigationHandle* navigation_handle) override;

Powered by Google App Engine
This is Rietveld 408576698