Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2498313002: Rewrite editing/spelling/inline-spelling-marker*.html (Closed)

Created:
4 years, 1 month ago by Xiaocheng
Modified:
4 years, 1 month ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rewrite editing/spelling/inline-spelling-marker*.html This patch rewrites the following layout tests: - editing/spelling/inline_spelling_markers.html - editing/spelling/inline-spelling-marker-hidpi.html - editing/spelling/inline-spelling-markers-hidpi-compositied.html These tests originally test both spell checker and marker appearance. This patch isolates the spell checking tests to a new layout test spellcheck_with_text_directions.html, and make the original tests verify marker appearance only. This patch hence simplifies the test cases, and also paves the road to implementing idle time spell checker. BUG=517298 Committed: https://crrev.com/3bb87520e1dfdda1c65596bb79daa4771f6d082a Cr-Commit-Position: refs/heads/master@{#432404}

Patch Set 1 #

Patch Set 2 : rebaselined #

Patch Set 3 : Add warning div #

Unified diffs Side-by-side diffs Delta from patch set Stats (+477 lines, -317 lines) Patch
M third_party/WebKit/LayoutTests/editing/spelling/inline-spelling-markers-hidpi.html View 1 2 3 chunks +40 lines, -66 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/spelling/inline-spelling-markers-hidpi-composited.html View 1 2 3 chunks +40 lines, -66 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/inline-spelling-markers-hidpi-composited-expected.txt View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/inline-spelling-markers-hidpi-expected.txt View 1 chunk +0 lines, -40 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/spelling/inline_spelling_markers.html View 1 2 3 chunks +37 lines, -65 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/inline_spelling_markers-expected.txt View 1 chunk +0 lines, -40 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/spelling/spellcheck_with_text_directions.html View 1 chunk +63 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/editing/spelling/inline-spelling-markers-hidpi-composited-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/editing/spelling/inline-spelling-markers-hidpi-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/editing/spelling/inline-spelling-markers-hidpi-composited-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/editing/spelling/inline-spelling-markers-hidpi-composited-expected.txt View 1 1 chunk +33 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/editing/spelling/inline-spelling-markers-hidpi-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/editing/spelling/inline-spelling-markers-hidpi-expected.txt View 1 1 chunk +33 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/editing/spelling/inline_spelling_markers-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/editing/spelling/inline_spelling_markers-expected.txt View 1 1 chunk +33 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mac10.10/editing/spelling/inline-spelling-markers-hidpi-composited-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mac10.10/editing/spelling/inline-spelling-markers-hidpi-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mac10.10/editing/spelling/inline_spelling_markers-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mac10.9/editing/spelling/inline-spelling-markers-hidpi-composited-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/editing/spelling/inline-spelling-markers-hidpi-composited-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/editing/spelling/inline-spelling-markers-hidpi-composited-expected.txt View 1 1 chunk +33 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/editing/spelling/inline-spelling-markers-hidpi-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/editing/spelling/inline-spelling-markers-hidpi-expected.txt View 1 1 chunk +33 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/editing/spelling/inline_spelling_markers-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/editing/spelling/inline_spelling_markers-expected.txt View 1 1 chunk +33 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/editing/spelling/inline-spelling-markers-hidpi-composited-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/editing/spelling/inline-spelling-markers-hidpi-composited-expected.txt View 1 1 chunk +33 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/editing/spelling/inline-spelling-markers-hidpi-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/editing/spelling/inline-spelling-markers-hidpi-expected.txt View 1 1 chunk +33 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/editing/spelling/inline_spelling_markers-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/editing/spelling/inline_spelling_markers-expected.txt View 1 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
Xiaocheng
PTAL.
4 years, 1 month ago (2016-11-15 13:07:18 UTC) #5
yosin_UTC9
As same as http://crrev.com/2498313002: Rewrite editing/spelling/inline-spelling-marker*.html We want to have pages to show warning when ...
4 years, 1 month ago (2016-11-16 01:52:33 UTC) #8
Xiaocheng
Updated. PTAL.
4 years, 1 month ago (2016-11-16 05:27:47 UTC) #11
yosin_UTC9
lgtm
4 years, 1 month ago (2016-11-16 06:01:05 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2498313002/40001
4 years, 1 month ago (2016-11-16 06:01:48 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-16 06:41:40 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 06:48:42 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3bb87520e1dfdda1c65596bb79daa4771f6d082a
Cr-Commit-Position: refs/heads/master@{#432404}

Powered by Google App Engine
This is Rietveld 408576698