Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 2498163003: Revert of [serializer] print use count of external references. (Closed)

Created:
4 years, 1 month ago by Michael Achenbach
Modified:
4 years, 1 month ago
Reviewers:
peria, vogelheim, Yang
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [serializer] print use count of external references. (patchset #2 id:20001 of https://codereview.chromium.org/2495213003/ ) Reason for revert: Breaks https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20vtunejit/builds/14690 compile Original issue's description: > [serializer] print use count of external references. > > R=peria@chromium.org, vogelheim@chromium.org > BUG=chromium:617892 > NOPRESUBMIT=true TBR=peria@chromium.org,vogelheim@chromium.org,yangguo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:617892 Committed: https://crrev.com/42d8a1d89b4ea52ba654fc831c1454aa4844dc73 Cr-Commit-Position: refs/heads/master@{#40980}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -79 lines) Patch
M src/api.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M src/external-reference-table.h View 1 chunk +0 lines, -12 lines 0 comments Download
M src/external-reference-table.cc View 4 chunks +8 lines, -38 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/snapshot/serializer-common.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/snapshot/serializer-common.cc View 2 chunks +14 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [serializer] print use count of external references.
4 years, 1 month ago (2016-11-15 07:42:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2498163003/1
4 years, 1 month ago (2016-11-15 07:42:49 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-15 07:43:01 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:33:27 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42d8a1d89b4ea52ba654fc831c1454aa4844dc73
Cr-Commit-Position: refs/heads/master@{#40980}

Powered by Google App Engine
This is Rietveld 408576698