Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: src/external-reference-table.cc

Issue 2498163003: Revert of [serializer] print use count of external references. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/external-reference-table.h ('k') | src/flag-definitions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/external-reference-table.cc
diff --git a/src/external-reference-table.cc b/src/external-reference-table.cc
index 7ad5e43aa8bf1575dd04d23805960d165ba5a262..aa61117c97392b3593ac792bb99e37076480b0db 100644
--- a/src/external-reference-table.cc
+++ b/src/external-reference-table.cc
@@ -10,11 +10,6 @@
#include "src/counters.h"
#include "src/deoptimizer.h"
#include "src/ic/stub-cache.h"
-
-#if defined(DEBUG) && defined(V8_OS_LINUX) && !defined(V8_OS_ANDROID)
-#define SYMBOLIZE_FUNCTION
-#include <execinfo.h>
-#endif // DEBUG && V8_OS_LINUX && !V8_OS_ANDROID
namespace v8 {
namespace internal {
@@ -46,28 +41,6 @@
AddStubCache(isolate);
AddDeoptEntries(isolate);
AddApiReferences(isolate);
-}
-
-#ifdef DEBUG
-void ExternalReferenceTable::ResetCount() {
- for (ExternalReferenceEntry& entry : refs_) entry.count = 0;
-}
-
-void ExternalReferenceTable::PrintCount() {
- for (int i = 0; i < refs_.length(); i++) {
- v8::base::OS::Print("index=%5d count=%5d %-60s\n", i, refs_[i].count,
- refs_[i].name);
- }
-}
-#endif // DEBUG
-
-// static
-const char* ExternalReferenceTable::ResolveSymbol(void* address) {
-#ifdef SYMBOLIZE_FUNCTION
- return backtrace_symbols(&address, 1)[0];
-#else
- return "<unresolved>";
-#endif // SYMBOLIZE_FUNCTION
}
void ExternalReferenceTable::AddReferences(Isolate* isolate) {
@@ -363,24 +336,22 @@
};
static const AccessorRefTable getters[] = {
-#define ACCESSOR_INFO_DECLARATION(name) \
- { FUNCTION_ADDR(&Accessors::name##Getter), \
- "Redirect to Accessors::" #name "Getter"},
- ACCESSOR_INFO_LIST(ACCESSOR_INFO_DECLARATION)
+#define ACCESSOR_INFO_DECLARATION(name) \
+ {FUNCTION_ADDR(&Accessors::name##Getter), "Accessors::" #name "Getter"},
+ ACCESSOR_INFO_LIST(ACCESSOR_INFO_DECLARATION)
#undef ACCESSOR_INFO_DECLARATION
};
static const AccessorRefTable setters[] = {
#define ACCESSOR_SETTER_DECLARATION(name) \
- { FUNCTION_ADDR(&Accessors::name), "Accessors::" #name},
- ACCESSOR_SETTER_LIST(ACCESSOR_SETTER_DECLARATION)
+ {FUNCTION_ADDR(&Accessors::name), "Accessors::" #name},
+ ACCESSOR_SETTER_LIST(ACCESSOR_SETTER_DECLARATION)
#undef ACCESSOR_INFO_DECLARATION
};
for (unsigned i = 0; i < arraysize(getters); ++i) {
- const char* name = getters[i].name + 12; // Skip "Redirect to " prefix.
- Add(getters[i].address, name);
+ Add(getters[i].address, getters[i].name);
Add(AccessorInfo::redirect(isolate, getters[i].address, ACCESSOR_GETTER),
- getters[i].name);
+ "");
}
for (unsigned i = 0; i < arraysize(setters); ++i) {
@@ -441,8 +412,7 @@
intptr_t* api_external_references = isolate->api_external_references();
if (api_external_references != nullptr) {
while (*api_external_references != 0) {
- Address address = reinterpret_cast<Address>(*api_external_references);
- Add(address, ResolveSymbol(address));
+ Add(reinterpret_cast<Address>(*api_external_references), "<embedder>");
api_external_references++;
}
}
« no previous file with comments | « src/external-reference-table.h ('k') | src/flag-definitions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698