Add field to monitor last visited time for each search engine

components/search_engines/template_url_data_util.cc

Index: components/search_engines/template_url_data_util.cc
diff --git a/components/search_engines/template_url_data_util.cc b/components/search_engines/template_url_data_util.cc
index 77ad25fd96a71e8695c6704659b1c318e1b62309..dc06c4ee58dd72d1e258c6deb72e9d056f00c8ad 100644
--- a/components/search_engines/template_url_data_util.cc
+++ b/components/search_engines/template_url_data_util.cc
@@ -67,8 +67,10 @@ std::unique_ptr<TemplateURLData> TemplateURLDataFromDictionary(
 
   std::string date_created_str;
   std::string last_modified_str;
+  std::string last_visited_str;
   dict.GetString(DefaultSearchManager::kDateCreated, &date_created_str);
   dict.GetString(DefaultSearchManager::kLastModified, &last_modified_str);
+  dict.GetString(DefaultSearchManager::kLastVisited, &last_visited_str);
 
   int64_t date_created = 0;
   if (base::StringToInt64(date_created_str, &date_created)) {
@@ -76,10 +78,15 @@ std::unique_ptr<TemplateURLData> TemplateURLDataFromDictionary(
   }
 
   int64_t last_modified = 0;
-  if (base::StringToInt64(date_created_str, &last_modified)) {
+  if (base::StringToInt64(last_modified_str, &last_modified)) {

[Peter Kasting, 2016/12/01 07:38:24]

Woah, this looks like it was a flat-out existing bug.  Can we add a test that
would have caught this?  (Maybe this fix + the test should be done in a separate
CL so it's easy to review and/or merge back?)

[ltian, 2016/12/01 10:02:58]

Yeah, this is the reason caused the problem that the last_modified resets back
once a TemplateURL is set as default. I will change it back and create a new CL
to fix this bug and add a test for it. 

     result->last_modified = base::Time::FromInternalValue(last_modified);
   }
 
+  int64_t last_visited = 0;
+  if (base::StringToInt64(last_visited_str, &last_visited)) {

[Peter Kasting, 2016/12/01 07:38:24]

Nit: This file is inconsistent about whether it uses {} or not on single-line
conditional bodies.  Here and in the two conditionals above we do, but in the
innermost two conditional just below we don't.

While here, I would make these consistent.  I'd probably omit {} as that's more
common within Chromium.

[ltian, 2016/12/01 10:02:58]

Done.

+    result->last_visited = base::Time::FromInternalValue(last_visited);
+  }
+
   dict.GetInteger(DefaultSearchManager::kUsageCount, &result->usage_count);
 
   const base::ListValue* alternate_urls = nullptr;
@@ -147,6 +154,9 @@ std::unique_ptr<base::DictionaryValue> TemplateURLDataToDictionary(
   url_dict->SetString(
       DefaultSearchManager::kLastModified,
       base::Int64ToString(data.last_modified.ToInternalValue()));
+  url_dict->SetString(
+      DefaultSearchManager::kLastVisited,
+      base::Int64ToString(data.last_visited.ToInternalValue()));
   url_dict->SetInteger(DefaultSearchManager::kUsageCount, data.usage_count);
 
   auto alternate_urls = base::MakeUnique<base::ListValue>();