Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: src/compiler.cc

Issue 2497933002: [Interpreter] Fix runtime-profiler ticks for Interpreted functions. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/runtime-profiler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index a8cf14c620079bdd7a202972aad68873a5d56311..28a4a2c3f7ff32e520b01313d360bf302c66f891 100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -643,6 +643,9 @@ MaybeHandle<Code> GetOptimizedCode(Handle<JSFunction> function,
if (shared->is_compiled()) {
Michael Starzinger 2016/11/14 15:36:49 question: I know this code was here before, but wo
rmcilroy 2016/11/14 17:24:26 Hmm, yeah that makes sense. I'll change it here an
shared->code()->set_profiler_ticks(0);
}
+ if (shared->HasBytecodeArray()) {
+ shared->set_profiler_ticks(0);
+ }
VMState<COMPILER> state(isolate);
DCHECK(!isolate->has_pending_exception());
@@ -735,6 +738,9 @@ CompilationJob::Status FinalizeOptimizedCompilationJob(CompilationJob* job) {
Handle<SharedFunctionInfo> shared = info->shared_info();
shared->code()->set_profiler_ticks(0);
Michael Starzinger 2016/11/14 15:36:49 Likewise.
rmcilroy 2016/11/14 17:24:26 Done.
+ if (shared->HasBytecodeArray()) {
+ shared->set_profiler_ticks(0);
+ }
DCHECK(!shared->HasDebugInfo());
« no previous file with comments | « no previous file | src/runtime-profiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698