[Interpreter] Fix runtime-profiler ticks for Interpreted functions.

src/compiler.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler.h"
 
 #include <algorithm>
 #include <memory>
 
 #include "src/asmjs/asm-js.h"
@@ skipping 622 matching lines @@
       function->ShortPrint();
       if (!osr_ast_id.IsNone()) {
         PrintF(" at OSR AST id %d", osr_ast_id.ToInt());
       }
       PrintF("]\n");
     }
     return cached_code;
   }
 
   // Reset profiler ticks, function is no longer considered hot.
   if (shared->is_compiled()) {

[Michael Starzinger, 2016/11/14 15:36:49]

question: I know this code was here before, but would using the
{SharedFunctionInfo::HasBaselineCode} predicate be more accurate here? If you
feel we shouldn't touch it as part of this CL then that's totally fine, just
wanted to throw out my thoughts here.

[rmcilroy, 2016/11/14 17:24:26]

Hmm, yeah that makes sense. I'll change it here and see what happens. Also made
this an if/else, so that we only reset the shared profiler ticks if there isn't
baseline code (so only affect the Ignition->TF, not the FCG->Crankshaft path)

     shared->code()->set_profiler_ticks(0);
   }
+  if (shared->HasBytecodeArray()) {
+    shared->set_profiler_ticks(0);
+  }
 
   VMState<COMPILER> state(isolate);
   DCHECK(!isolate->has_pending_exception());
   PostponeInterruptsScope postpone(isolate);
   bool use_turbofan = UseTurboFan(shared) || ignition_osr;
   std::unique_ptr<CompilationJob> job(
       use_turbofan ? compiler::Pipeline::NewCompilationJob(function)
                    : new HCompilationJob(function));
   CompilationInfo* info = job->info();
   ParseInfo* parse_info = info->parse_info();
@@ skipping 71 matching lines @@
   CompilationInfo* info = job->info();
   Isolate* isolate = info->isolate();
 
   TimerEventScope<TimerEventRecompileSynchronous> timer(info->isolate());
   RuntimeCallTimerScope runtimeTimer(isolate,
                                      &RuntimeCallStats::RecompileSynchronous);
   TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("v8.compile"),
                "V8.RecompileSynchronous");
 
   Handle<SharedFunctionInfo> shared = info->shared_info();
   shared->code()->set_profiler_ticks(0);

[Michael Starzinger, 2016/11/14 15:36:49]

Likewise.

[rmcilroy, 2016/11/14 17:24:26]

Done.

+  if (shared->HasBytecodeArray()) {
+    shared->set_profiler_ticks(0);
+  }
 
   DCHECK(!shared->HasDebugInfo());
 
   // 1) Optimization on the concurrent thread may have failed.
   // 2) The function may have already been optimized by OSR.  Simply continue.
   //    Except when OSR already disabled optimization for some reason.
   // 3) The code may have already been invalidated due to dependency change.
   // 4) Code generation may have failed.
   if (job->state() == CompilationJob::State::kReadyToFinalize) {
     if (shared->optimization_disabled()) {
@@ skipping 963 matching lines @@
     DCHECK(shared->is_compiled());
     function->set_literals(cached.literals);
   } else if (shared->is_compiled()) {
     // TODO(mvstanton): pass pretenure flag to EnsureLiterals.
     JSFunction::EnsureLiterals(function);
   }
 }
 
 }  // namespace internal
 }  // namespace v8