[Interpreter] Fix runtime-profiler ticks for Interpreted functions.

[Interpreter] Fix runtime-profiler ticks for Interpreted functions.

Fix two bugs with the runtime-profiler optimization heuristics for
interpreted code:
 - Reset shared->tick_count for interpreted functions when optimizing
 - Update ticks after checking whether to optimize functions, to be the
   same as the FCG profiler checks (where updates are done to the code
   ticks after deciding whether to optimize).

BUG=chromium:662071
Committed: https://crrev.com/aed65cb45ab1e816bead2895bb56ca6a77137136
Cr-Commit-Position: refs/heads/master@{#40978}

[rmcilroy, 2016-11-14 14:57:15]

rmcilroy@chromium.org changed reviewers:
+ mstarzinger@chromium.org, mythria@chromium.org

[rmcilroy, 2016-11-14 14:57:15]

Michi / Mythri, PTAL, thanks.

[Michael Starzinger, 2016-11-14 15:36:49]

LGTM.

https://codereview.chromium.org/2497933002/diff/1/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/2497933002/diff/1/src/compiler.cc#newcode643
src/compiler.cc:643: if (shared->is_compiled()) {
question: I know this code was here before, but would using the
{SharedFunctionInfo::HasBaselineCode} predicate be more accurate here? If you
feel we shouldn't touch it as part of this CL then that's totally fine, just
wanted to throw out my thoughts here.

https://codereview.chromium.org/2497933002/diff/1/src/compiler.cc#newcode740
src/compiler.cc:740: shared->code()->set_profiler_ticks(0);
Likewise.

[mythria, 2016-11-14 15:55:11]

LGTM.

[rmcilroy, 2016-11-14 17:24:26]

https://codereview.chromium.org/2497933002/diff/1/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/2497933002/diff/1/src/compiler.cc#newcode643
src/compiler.cc:643: if (shared->is_compiled()) {
On 2016/11/14 15:36:49, Michael Starzinger wrote:
> question: I know this code was here before, but would using the
> {SharedFunctionInfo::HasBaselineCode} predicate be more accurate here? If you
> feel we shouldn't touch it as part of this CL then that's totally fine, just
> wanted to throw out my thoughts here.

Hmm, yeah that makes sense. I'll change it here and see what happens. Also made
this an if/else, so that we only reset the shared profiler ticks if there isn't
baseline code (so only affect the Ignition->TF, not the FCG->Crankshaft path)

https://codereview.chromium.org/2497933002/diff/1/src/compiler.cc#newcode740
src/compiler.cc:740: shared->code()->set_profiler_ticks(0);
On 2016/11/14 15:36:49, Michael Starzinger wrote:
> Likewise.

Done.

[rmcilroy, 2016-11-14 17:24:30]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 17:24:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 17:49:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 17:49:56]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2016-11-14 20:30:25]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2016-11-14 20:30:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org, mythria@chromium.org
Link to the patchset: https://codereview.chromium.org/2497933002/#ps20001
(title: "Review comments")

[commit-bot: I haz the power, 2016-11-14 20:30:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 05:45:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-17 22:33:20]

Description was changed from

==========
[Interpreter] Fix runtime-profiler ticks for Interpreted functions.

Fix two bugs with the runtime-profiler optimization heuristics for
interpreted code:
 - Reset shared->tick_count for interpreted functions when optimizing
 - Update ticks after checking whether to optimize functions, to be the
   same as the FCG profiler checks (where updates are done to the code
   ticks after deciding whether to optimize).

BUG=chromium:662071
==========

to

==========
[Interpreter] Fix runtime-profiler ticks for Interpreted functions.

Fix two bugs with the runtime-profiler optimization heuristics for
interpreted code:
 - Reset shared->tick_count for interpreted functions when optimizing
 - Update ticks after checking whether to optimize functions, to be the
   same as the FCG profiler checks (where updates are done to the code
   ticks after deciding whether to optimize).

BUG=chromium:662071

Committed: https://crrev.com/aed65cb45ab1e816bead2895bb56ca6a77137136
Cr-Commit-Position: refs/heads/master@{#40978}
==========

[commit-bot: I haz the power, 2016-11-17 22:33:21]

Patchset 2 (id:??) landed as
https://crrev.com/aed65cb45ab1e816bead2895bb56ca6a77137136
Cr-Commit-Position: refs/heads/master@{#40978}