Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2497833002: support multiple log message handlers in base/logging.h (Closed)

Created:
4 years, 1 month ago by rkuksin
Modified:
4 years, 1 month ago
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, cbentzel+watch_chromium.org, jam, sadrul, ntp-dev+reviews_chromium.org, chromoting-reviews_chromium.org, wfh+watch_chromium.org, samuong+watch_chromium.org, mac-reviews_chromium.org, phoglund+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, grt+watch_chromium.org, tracing+reviews_chromium.org, kalyank, sdefresne+watch_chromium.org, pedrosimonetti+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -166 lines) Patch
M base/logging.h View 1 chunk +5 lines, -3 lines 0 comments Download
M base/logging.cc View 5 chunks +31 lines, -12 lines 0 comments Download
M base/logging_win.h View 1 chunk +4 lines, -2 lines 0 comments Download
M base/logging_win.cc View 5 chunks +7 lines, -10 lines 0 comments Download
M base/test/mock_log.h View 2 chunks +3 lines, -8 lines 0 comments Download
M base/test/mock_log.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M base/trace_event/trace_event_unittest.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/media/webrtc/webrtc_browsertest_base.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database_unittest.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/test/base/web_ui_browser_test.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M chrome/test/chromedriver/logging.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M components/crash/content/app/breakpad_mac.mm View 3 chunks +10 lines, -9 lines 0 comments Download
M components/crash/content/app/crashpad.cc View 3 chunks +11 lines, -13 lines 0 comments Download
M components/proximity_auth/logging/logging_unittest.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M content/gpu/gpu_main.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M ios/chrome/browser/crash_report/breakpad_helper.mm View 3 chunks +11 lines, -11 lines 0 comments Download
M net/tools/stress_cache/stress_cache.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M remoting/client/plugin/chromoting_instance.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M remoting/host/logging_mac.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M remoting/host/native_messaging/log_message_handler.h View 2 chunks +1 line, -2 lines 0 comments Download
M remoting/host/native_messaging/log_message_handler.cc View 3 chunks +7 lines, -15 lines 0 comments Download
M third_party/crashpad/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/thread/thread_log_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/thread/thread_log_messages.cc View 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rkuksin
4 years, 1 month ago (2016-11-14 04:01:47 UTC) #1
Dan Beam
please coordinate / reconcile with: https://codereview.chromium.org/2034393004/
4 years, 1 month ago (2016-11-14 07:47:59 UTC) #3
rkuksin
4 years, 1 month ago (2016-11-14 08:26:57 UTC) #5
Message was sent while issue was closed. 
On 2016/11/14 07:47:59, Dan Beam wrote:
> please coordinate / reconcile with:
> https://codereview.chromium.org/2034393004/

Closed as a duplicate.

Powered by Google App Engine
This is Rietveld 408576698