| OLD | NEW |
| 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include <stddef.h> | 5 #include <stddef.h> |
| 6 | 6 |
| 7 #include "base/command_line.h" | 7 #include "base/command_line.h" |
| 8 #include "base/logging.h" | 8 #include "base/logging.h" |
| 9 #include "chrome/browser/ui/browser.h" | 9 #include "chrome/browser/ui/browser.h" |
| 10 #include "chrome/browser/ui/browser_commands.h" | 10 #include "chrome/browser/ui/browser_commands.h" |
| (...skipping 10 matching lines...) Expand all Loading... |
| 21 #include "url/gurl.h" | 21 #include "url/gurl.h" |
| 22 | 22 |
| 23 using content::OpenURLParams; | 23 using content::OpenURLParams; |
| 24 using content::Referrer; | 24 using content::Referrer; |
| 25 | 25 |
| 26 namespace { | 26 namespace { |
| 27 | 27 |
| 28 static bool had_console_errors = false; | 28 static bool had_console_errors = false; |
| 29 | 29 |
| 30 bool HandleMessage(int severity, | 30 bool HandleMessage(int severity, |
| 31 const char* file, | 31 const std::string& file, |
| 32 int line, | 32 int line, |
| 33 size_t message_start, | |
| 34 const std::string& str) { | 33 const std::string& str) { |
| 35 if (severity == logging::LOG_ERROR && file && file == std::string("CONSOLE")) | 34 if (severity == logging::LOG_ERROR && file == std::string("CONSOLE")) |
| 36 had_console_errors = true; | 35 had_console_errors = true; |
| 37 return false; | 36 return false; |
| 38 } | 37 } |
| 39 | 38 |
| 40 } // namespace | 39 } // namespace |
| 41 | 40 |
| 42 class NewTabUIBrowserTest : public InProcessBrowserTest { | 41 class NewTabUIBrowserTest : public InProcessBrowserTest { |
| 43 public: | 42 public: |
| 44 NewTabUIBrowserTest() { | 43 NewTabUIBrowserTest() { |
| 45 logging::SetLogMessageHandler(&HandleMessage); | 44 logging::AddLogMessageHandler(&HandleMessage); |
| 46 } | 45 } |
| 47 | 46 |
| 48 ~NewTabUIBrowserTest() override { logging::SetLogMessageHandler(NULL); } | 47 ~NewTabUIBrowserTest() override { |
| 48 logging::RemoveLogMessageHandler(&HandleMessage); |
| 49 } |
| 49 | 50 |
| 50 void TearDown() override { | 51 void TearDown() override { |
| 51 InProcessBrowserTest::TearDown(); | 52 InProcessBrowserTest::TearDown(); |
| 52 ASSERT_FALSE(had_console_errors); | 53 ASSERT_FALSE(had_console_errors); |
| 53 } | 54 } |
| 54 }; | 55 }; |
| 55 | 56 |
| 56 // Navigate to incognito NTP. Fails if there are console errors. | 57 // Navigate to incognito NTP. Fails if there are console errors. |
| 57 IN_PROC_BROWSER_TEST_F(NewTabUIBrowserTest, ShowIncognito) { | 58 IN_PROC_BROWSER_TEST_F(NewTabUIBrowserTest, ShowIncognito) { |
| 58 ui_test_utils::NavigateToURL(CreateIncognitoBrowser(), | 59 ui_test_utils::NavigateToURL(CreateIncognitoBrowser(), |
| (...skipping 29 matching lines...) Expand all Loading... |
| 88 | 89 |
| 89 // We don't use ui_test_utils::NavigateToURLWithDisposition because that waits | 90 // We don't use ui_test_utils::NavigateToURLWithDisposition because that waits |
| 90 // for current loading to stop. | 91 // for current loading to stop. |
| 91 content::TestNavigationObserver observer( | 92 content::TestNavigationObserver observer( |
| 92 browser()->tab_strip_model()->GetActiveWebContents()); | 93 browser()->tab_strip_model()->GetActiveWebContents()); |
| 93 browser()->OpenURL(OpenURLParams( | 94 browser()->OpenURL(OpenURLParams( |
| 94 GURL("data:text/html,hello world"), Referrer(), | 95 GURL("data:text/html,hello world"), Referrer(), |
| 95 WindowOpenDisposition::CURRENT_TAB, ui::PAGE_TRANSITION_TYPED, false)); | 96 WindowOpenDisposition::CURRENT_TAB, ui::PAGE_TRANSITION_TYPED, false)); |
| 96 observer.Wait(); | 97 observer.Wait(); |
| 97 } | 98 } |
| OLD | NEW |