Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1011)

Unified Diff: net/base/registry_controlled_domains/registry_controlled_domain.h

Issue 2497753002: Invert host/domain checks in SameDomainOrHost (Closed)
Patch Set: pkasting review Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/base/registry_controlled_domains/registry_controlled_domain.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/registry_controlled_domains/registry_controlled_domain.h
diff --git a/net/base/registry_controlled_domains/registry_controlled_domain.h b/net/base/registry_controlled_domains/registry_controlled_domain.h
index 9e631f6f130f99159bbaaba77b7c5519e3dd935f..429a5770cc2b26522d6f516a120750b57f03379b 100644
--- a/net/base/registry_controlled_domains/registry_controlled_domain.h
+++ b/net/base/registry_controlled_domains/registry_controlled_domain.h
@@ -190,9 +190,9 @@ NET_EXPORT std::string GetDomainAndRegistry(base::StringPiece host,
// These convenience functions return true if the two GURLs or Origins both have
// hosts and one of the following is true:
+// * The hosts are identical.
// * They each have a known domain and registry, and it is the same for both
// URLs. Note that this means the trailing dot, if any, must match too.
Peter Kasting 2016/11/14 23:21:03 This comment reordering makes me wonder if the fun
Charlie Harrison 2016/11/14 23:48:23 Yeah I don't think the rename is necessary, though
-// * They don't have known domains/registries, but the hosts are identical.
// Effectively, callers can use this function to check whether the input URLs
// represent hosts "on the same site".
NET_EXPORT bool SameDomainOrHost(const GURL& gurl1, const GURL& gurl2,
« no previous file with comments | « no previous file | net/base/registry_controlled_domains/registry_controlled_domain.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698