Invert host/domain checks in SameDomainOrHost

net/base/registry_controlled_domains/registry_controlled_domain.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // NB: Modelled after Mozilla's code (originally written by Pamela Greene,
 // later modified by others), but almost entirely rewritten for Chrome.
 //   (netwerk/dns/src/nsEffectiveTLDService.h)
 /* ***** BEGIN LICENSE BLOCK *****
  * Version: MPL 1.1/GPL 2.0/LGPL 2.1
  *
@@ skipping 172 matching lines @@
 NET_EXPORT std::string GetDomainAndRegistry(const GURL& gurl,
                                             PrivateRegistryFilter filter);
 
 // Like the GURL version, but takes a host (which is canonicalized internally)
 // instead of a full GURL.
 NET_EXPORT std::string GetDomainAndRegistry(base::StringPiece host,
                                             PrivateRegistryFilter filter);
 
 // These convenience functions return true if the two GURLs or Origins both have
 // hosts and one of the following is true:
+// * The hosts are identical.
 // * They each have a known domain and registry, and it is the same for both
 //   URLs.  Note that this means the trailing dot, if any, must match too.

[Peter Kasting, 2016/11/14 23:21:03]

This comment reordering makes me wonder if the function should be renamed
SameHostOrDomain() or maybe just OnSameSite() or something.

Probably that just mucks with a lot of code to little benefit, though.

[Charlie Harrison, 2016/11/14 23:48:23]

Yeah I don't think the rename is necessary, though I do agree it would be
slightly more accurate. The method is pretty much logical OR so I don't think a
re-ordering is super confusing.

-// * They don't have known domains/registries, but the hosts are identical.
 // Effectively, callers can use this function to check whether the input URLs
 // represent hosts "on the same site".
 NET_EXPORT bool SameDomainOrHost(const GURL& gurl1, const GURL& gurl2,
                                  PrivateRegistryFilter filter);
 NET_EXPORT bool SameDomainOrHost(const url::Origin& origin1,
                                  const url::Origin& origin2,
                                  PrivateRegistryFilter filter);
 // Note: this returns false if |origin2| is not set.
 NET_EXPORT bool SameDomainOrHost(const url::Origin& origin1,
                                  const base::Optional<url::Origin>& origin2,
@@ skipping 85 matching lines @@
 NET_EXPORT_PRIVATE void SetFindDomainGraph();
 
 // Used for unit tests, so that a frozen list of domains is used.
 NET_EXPORT_PRIVATE void SetFindDomainGraph(const unsigned char* domains,
                                            size_t length);
 
 }  // namespace registry_controlled_domains
 }  // namespace net
 
 #endif  // NET_BASE_REGISTRY_CONTROLLED_DOMAINS_REGISTRY_CONTROLLED_DOMAIN_H_