Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2497713002:
Disable system_health.memory_desktop on Win and Mac perf bots (Closed)
DescriptionDisable system_health.memory_desktop on Win and Mac perf bots
TBR=nednguyen@google.com
BUG=656040, 663025
Committed: https://crrev.com/57f0956c8472b744529cee20e6c64bd39fd84ec9
Cr-Commit-Position: refs/heads/master@{#431773}
Patch Set 1 #
Messages
Total messages: 16 (9 generated)
Description was changed from ========== Disable system_health.memory_desktop on Win and Mac perf bots BUG=chromium:656040,chromium:663025 ========== to ========== Disable system_health.memory_desktop on Win and Mac perf bots BUG=chromium:656040,chromium:663025 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Description was changed from ========== Disable system_health.memory_desktop on Win and Mac perf bots BUG=chromium:656040,chromium:663025 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Disable system_health.memory_desktop on Win and Mac perf bots TBR=nednguyen@google.com BUG=chromium:656040,chromium:663025 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
The CQ bit was checked by zhenw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Disable system_health.memory_desktop on Win and Mac perf bots TBR=nednguyen@google.com BUG=chromium:656040,chromium:663025 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Disable system_health.memory_desktop on Win and Mac perf bots TBR=nednguyen@google.com BUG=656040,663025 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_retina_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
Description was changed from ========== Disable system_health.memory_desktop on Win and Mac perf bots TBR=nednguyen@google.com BUG=656040,663025 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Disable system_health.memory_desktop on Win and Mac perf bots TBR=nednguyen@google.com BUG=656040,663025 ==========
The CQ bit was checked by zhenw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Disable system_health.memory_desktop on Win and Mac perf bots TBR=nednguyen@google.com BUG=656040,663025 ========== to ========== Disable system_health.memory_desktop on Win and Mac perf bots TBR=nednguyen@google.com BUG=656040,663025 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Disable system_health.memory_desktop on Win and Mac perf bots TBR=nednguyen@google.com BUG=656040,663025 ========== to ========== Disable system_health.memory_desktop on Win and Mac perf bots TBR=nednguyen@google.com BUG=656040,663025 Committed: https://crrev.com/57f0956c8472b744529cee20e6c64bd39fd84ec9 Cr-Commit-Position: refs/heads/master@{#431773} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/57f0956c8472b744529cee20e6c64bd39fd84ec9 Cr-Commit-Position: refs/heads/master@{#431773}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2492323003/ by nednguyen@google.com. The reason for reverting is: Please don't disable the whole system health benchmark. Disable only the failing stories instead..
Message was sent while issue was closed.
On 2016/11/12 12:38:40, nednguyen wrote: > A revert of this CL (patchset #1 id:1) has been created in > https://codereview.chromium.org/2492323003/ by mailto:nednguyen@google.com. > > The reason for reverting is: Please don't disable the whole system health > benchmark. Disable only the failing stories instead.. Thanks! Will disable the failing ones. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
